Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/pkgs/numpy/lapack_conf.py: Use #! for interpreter that is actually used #31663

Closed
mkoeppe opened this issue Apr 12, 2021 · 8 comments
Closed

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Apr 12, 2021

(from #29039 comment:78)

numpy's spkg-install.in runs python3 lapack_conf.py (i.e., correctly, with the Sage python3), but lapack_conf.py confusingly indicates #!/usr/bin/env sage-bootstrap-python (which is the wrong Python; but in spkg-install.in, the script is not called by the shell, so this #! is not actually interpreted).

We remove this confusion in this ticket, but there is no functional change.

CC: @dimpase

Component: build

Author: Matthias Koeppe

Branch/Commit: 0ac27ff

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/31663

@mkoeppe mkoeppe added this to the sage-9.4 milestone Apr 12, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 12, 2021

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 12, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 12, 2021

Commit: 0ac27ff

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 12, 2021

New commits:

0ac27ffbuild/pkgs/numpy/lapack_conf.py: Change #! line to use python3. Decorative change only - spkg-install.in already explicitly uses python3 to call this script

@dimpase
Copy link
Member

dimpase commented Apr 12, 2021

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Apr 12, 2021

comment:3

thanks!

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 19, 2021

comment:4

Promoting the oldest 5 positively reviewed tickets to "major"

@vbraun
Copy link
Member

vbraun commented Jul 23, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants