Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more scalar conversions #31716

Closed
videlec opened this issue Apr 22, 2021 · 22 comments
Closed

more scalar conversions #31716

videlec opened this issue Apr 22, 2021 · 22 comments

Comments

@videlec
Copy link
Contributor

videlec commented Apr 22, 2021

Following #10147, we extend conversion to scalars for polynomials, multi-polynomials and fraction fields.

The attached branch allows the following construction

sage: x = polygen(QQ)
sage: A.<u> = NumberField(x^3 - 2)
sage: A((x + 3) / (2*x - 1))
14/15*u^2 + 7/15*u + 11/15

See the original report from asksage.

Component: basic arithmetic

Author: Vincent Delecroix

Branch: e40555a

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/31716

@videlec videlec added this to the sage-9.4 milestone Apr 22, 2021
@videlec
Copy link
Contributor Author

videlec commented Apr 22, 2021

Branch: u/vdelecroix/31716

@videlec
Copy link
Contributor Author

videlec commented Apr 22, 2021

Author: Vincent Delecroix

@videlec
Copy link
Contributor Author

videlec commented Apr 22, 2021

New commits:

76fdce331716: more scalar conversions

@videlec
Copy link
Contributor Author

videlec commented Apr 22, 2021

Commit: 76fdce3

@videlec

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 22, 2021

Changed commit from 76fdce3 to 9dbc024

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 22, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e2a22cb31716: more scalar conversions
9dbc02431716: fix doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 22, 2021

Changed commit from 9dbc024 to 4e245da

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 22, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

4e245da31716: more doctests

@videlec

This comment has been minimized.

@tscrim
Copy link
Collaborator

tscrim commented Apr 23, 2021

comment:7

LGTM except you lost the doctest for MPolynomial._integer_. Once you add one, you can set a positive review.

@tscrim
Copy link
Collaborator

tscrim commented Apr 23, 2021

Reviewer: Travis Scrimshaw

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 23, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

779b1admore tests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 23, 2021

Changed commit from 4e245da to 779b1ad

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 23, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

e40555a31716: remove MPolynomial._integer_

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 23, 2021

Changed commit from 779b1ad to e40555a

@videlec
Copy link
Contributor Author

videlec commented Apr 23, 2021

comment:10

Thanks for spotting that. My goal was actually to remove the _integer_ method (done in e40555a). I copied over the tests in _scalar_conversion (779b1ad).

@tscrim
Copy link
Collaborator

tscrim commented Apr 23, 2021

comment:11

Once the patchbot comes back green, positive review.

@videlec
Copy link
Contributor Author

videlec commented Apr 23, 2021

comment:12

green. Thanks.

@vbraun
Copy link
Member

vbraun commented Jun 19, 2021

Changed branch from u/vdelecroix/31716 to e40555a

@mezzarobba
Copy link
Member

Changed commit from e40555a to none

@mezzarobba
Copy link
Member

comment:14

I suspect (but have not checked) that #32078 was caused by the changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants