Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning with viewing KR crystals #31719

Closed
tscrim opened this issue Apr 23, 2021 · 7 comments
Closed

Fix deprecation warning with viewing KR crystals #31719

tscrim opened this issue Apr 23, 2021 · 7 comments

Comments

@tscrim
Copy link
Collaborator

tscrim commented Apr 23, 2021

We have the following:

sage: K = crystals.KirillovReshetikhin(['A',2,1], 2,1)
sage: view(K)
/sage-build/local/lib/python3.9/site-packages/sage/misc/decorators.py:491:
 DeprecationWarning: parameter {'backward':True} (in edge_options) is deprecated.
 Use {'dir':'back'} instead.
See https://trac.sagemath.org/31381 for details.
  return func(*args, **options)

We update the edge option function according to #31381.

CC: @sagetrac-sage-combinat @dwbump @anneschilling @nthiery @fchapoton @seblabbe

Component: combinatorics

Keywords: crystals, latex

Author: Travis Scrimshaw

Branch/Commit: 0354a41

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/31719

@tscrim tscrim added this to the sage-9.4 milestone Apr 23, 2021
@tscrim
Copy link
Collaborator Author

tscrim commented Apr 23, 2021

comment:1

Simple fix.


New commits:

0354a41Fix deprecation warning for viewing crystals with graphviz.

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 23, 2021

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 23, 2021

Commit: 0354a41

@fchapoton
Copy link
Contributor

comment:2

ok

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 24, 2021

comment:3

Thank you.

@vbraun
Copy link
Member

vbraun commented Jul 1, 2021

Changed branch from public/crystals/fix_edge_options-31719 to 0354a41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants