Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIPVariable: Change to a subclass of FiniteFamily #31750

Closed
mkoeppe opened this issue Apr 28, 2021 · 18 comments · Fixed by #35121
Closed

MIPVariable: Change to a subclass of FiniteFamily #31750

mkoeppe opened this issue Apr 28, 2021 · 18 comments · Fixed by #35121
Labels
c: linear programming p: major / 3 t: enhancement
Milestone
sage-10.3

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Apr 28, 2021 •
edited

... to give it a richer set of operations, such as len() to get the number of components and an implementation of .inverse_family() to allow looking up the key of a given component (LinearFunction instance).

This requires making AbstractFamily and FiniteFamily Cython classes.

Depends on #34839

CC: @yuan-zhou @tscrim @mantepse

Component: linear programming

Author: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/31750
@mkoeppe mkoeppe added this to the sage-9.4 milestone Apr 28, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Mar 5, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 3, 2023

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 3, 2023

Branch: u/mkoeppe/mipvariable__change_to_a_subclass_of_finitefamily

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 3, 2023

Commit: 3beb977

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 3, 2023

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

96366a6sage.sets.family: Cythonize
3beb977MIPVariable: Make it a subclass of FiniteFamily

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 3, 2023

Branch pushed to git repo; I updated commit sha1. New commits:

a278c80src/sage/sets/family.py: Update copyright according to git blame -w --date=format:%Y FILE | sort -k2
11aeb80sage.sets.family: Fix pickling

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 3, 2023

Changed commit from 3beb977 to 11aeb80

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 4, 2023

comment:11
sage -t --random-seed=163374757519390176193284183888236547352 doc/en/thematic_tutorials/lie/weyl_groups.rst  # 2 doctests failed
sage -t --random-seed=163374757519390176193284183888236547352 sage/algebras/fusion_rings/fusion_ring.py  # 17 doctests failed
sage -t --random-seed=163374757519390176193284183888236547352 sage/algebras/iwahori_hecke_algebra.py  # 3 doctests failed
sage -t --random-seed=163374757519390176193284183888236547352 sage/algebras/lie_algebras/nilpotent_lie_algebra.py  # 10 doctests failed
sage -t --random-seed=163374757519390176193284183888236547352 sage/algebras/lie_algebras/quotient.py  # 7 doctests failed
sage -t --random-seed=163374757519390176193284183888236547352 sage/algebras/lie_algebras/subalgebra.py  # 4 doctests failed
sage -t --random-seed=163374757519390176193284183888236547352 sage/categories/finite_dimensional_algebras_with_basis.py  # 26 doctests failed
sage -t --random-seed=163374757519390176193284183888236547352 sage/categories/finite_dimensional_lie_algebras_with_basis.py  # 3 doctests failed
sage -t --random-seed=163374757519390176193284183888236547352 sage/categories/finite_dimensional_semisimple_algebras_with_basis.py  # 9 doctests failed
sage -t --random-seed=163374757519390176193284183888236547352 sage/categories/lie_algebras.py  # 2 doctests failed
sage -t --random-seed=163374757519390176193284183888236547352 sage/groups/lie_gps/nilpotent_lie_group.py  # 2 doctests failed
sage -t --random-seed=163374757519390176193284183888236547352 sage/modules/with_basis/morphism.py  # 1 doctest failed
sage -t --random-seed=163374757519390176193284183888236547352 sage/modules/with_basis/subquotient.py  # 2 doctests failed
sage -t --random-seed=163374757519390176193284183888236547352 sage/sets/family.pyx  # 1 doctest failed

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 4, 2023

Changed commit from 11aeb80 to d312578

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 4, 2023

Branch pushed to git repo; I updated commit sha1. New commits:

d312578src/sage/sets/family.pxd: Make attributes public

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 4, 2023

Changed commit from d312578 to 450f9c6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 4, 2023

Branch pushed to git repo; I updated commit sha1. New commits:

450f9c6Make FiniteFamily a Python subclass of FiniteFamily_base - so that EnumeratedSets mixins work correctly

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 4, 2023

Dependencies: #34839

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 4, 2023

Branch pushed to git repo; I updated commit sha1. New commits:

d302a62tox.ini, src/tox.ini: Adjust to tox 4, autoprovision tox >= 3.18
f8703ae.github/workflows/lint.yml: Invoke tox with --
9d76204fix some rst issues in sage_docbuild and sage_setup
70da140Merge branch 'u/chapoton/support_tox_4' in 9.8.b6
8b2ada9Merge #34839

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 4, 2023

Changed commit from 450f9c6 to 8b2ada9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 7, 2023

Changed commit from 8b2ada9 to 02ffd0a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 7, 2023

Branch pushed to git repo; I updated commit sha1. New commits:

e521c9cRevert "Make FiniteFamily a Python subclass of FiniteFamily_base - so that EnumeratedSets mixins work correctly"
02ffd0aFiniteFamily: Simpler solution that makes EnumeratedSets mixins work correctly

@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 29, 2023
This was referenced Jan 29, 2023
Open
Open
@mkoeppe mkoeppe mentioned this issue Feb 13, 2023
Merged
4 tasks
@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 13, 2023

Removed branch from issue description; replaced by PR #35121

@mkoeppe mkoeppe modified the milestones: sage-10.0, sage-10.1 Apr 30, 2023
@mkoeppe mkoeppe removed this from the sage-10.1 milestone Aug 7, 2023
@vbraun vbraun closed this as completed in 2017233 Dec 19, 2023
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: linear programming p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging a pull request may close this issue.

sage.sets.family: Cythonize; change MIPVariable to a subclass of FiniteFamily mkoeppe/sage
1 participant
@mkoeppe