Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDF() should return CDF.zero() #31836

Closed
sagetrac-tmonteil mannequin opened this issue May 18, 2021 · 14 comments
Closed

CDF() should return CDF.zero() #31836

sagetrac-tmonteil mannequin opened this issue May 18, 2021 · 14 comments

Comments

@sagetrac-tmonteil
Copy link
Mannequin

sagetrac-tmonteil mannequin commented May 18, 2021

We have:

sage: RR()
0.000000000000000
sage: CC()
0.000000000000000
sage: RIF()
0
sage: CIF()
0
sage: RBF()
0
sage: CBF()
0
sage: RDF()
0.0
sage: CDF()
TypeError: __call__() takes at least 1 positional argument (0 given)

Expected :

sage: CDF()
0.0

Most real field implementations rely on Parent.__call__ while complex ones have to define their own __call__ method in order to accept constructions like CC(a,b), but the implementation of CDF misses the empty case.

Component: basic arithmetic

Author: Thierry Monteil

Branch/Commit: f50e0ea

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/31836

@sagetrac-tmonteil sagetrac-tmonteil mannequin added this to the sage-9.4 milestone May 18, 2021
@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented May 18, 2021

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented May 18, 2021

Commit: 697ed2c

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented May 18, 2021

New commits:

697ed2c#31836 : CDF() should return CDF.zero()

@sagetrac-tmonteil

This comment has been minimized.

@sagetrac-tmonteil

This comment has been minimized.

@fchapoton
Copy link
Contributor

comment:4

TESTS:: a un : de trop

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 18, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

4f520bf#31836 : typo

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 18, 2021

Changed commit from 697ed2c to 4f520bf

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 18, 2021

Changed commit from 4f520bf to f50e0ea

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 18, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f50e0ea#31836 : typo

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented May 18, 2021

comment:7

Désolé.

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:8

ok, allons-y

@vbraun
Copy link
Member

vbraun commented Jun 21, 2021

Changed branch from u/tmonteil/cdf___should_return_cdf_zero__ to f50e0ea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants