Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some details in references in various files #31857

Closed
fchapoton opened this issue May 25, 2021 · 14 comments
Closed

some details in references in various files #31857

fchapoton opened this issue May 25, 2021 · 14 comments

Comments

@fchapoton
Copy link
Contributor

found using

git grep "^[^#]*\[[A-Z][A-Za-z]*[0-9][0-9]*\]\s[A-Z]\." 

CC: @slel

Component: documentation

Author: Frédéric Chapoton

Branch/Commit: 0554d48

Reviewer: Samuel Lelièvre

Issue created by migration from https://trac.sagemath.org/ticket/31857

@fchapoton fchapoton added this to the sage-9.4 milestone May 25, 2021
@fchapoton
Copy link
Contributor Author

New commits:

f32111asome details in references in various files

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/31857

@fchapoton
Copy link
Contributor Author

Commit: f32111a

@fchapoton

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 25, 2021

Changed commit from f32111a to f0bd85b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 25, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

f0bd85busing doi once more

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 25, 2021

Changed commit from f0bd85b to 0554d48

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 25, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

0554d48trying to fix ref

@slel
Copy link
Member

slel commented May 25, 2021

Reviewer: Samuel Lelièvre

@slel
Copy link
Member

slel commented May 25, 2021

comment:5

This improves the references in

  • src/doc/en/thematic_tutorials/geometry/polyhedra_tutorial.rst
  • src/sage/coding/self_dual_codes.py
  • src/sage/combinat/rsk.py
  • src/sage/groups/abelian_gps/abelian_group.py
  • src/sage/matrix/matrix0.pyx

moving one of them to src/doc/en/reference/references/index.rst.

If you don't plan to move more refs to the main
references file here, good to go.

@fchapoton
Copy link
Contributor Author

comment:6

merci

j'attend le patchbot, je soupconne encore un probleme avec la doc

@slel
Copy link
Member

slel commented Jun 19, 2021

comment:7

Le patchbot signale uniquement quelques affectations non utilisées.

Dans src/sage/coding/self_dual_codes.py:

576:9 local variable 'I18' is assigned to but never used
594:9 local variable 'G' is assigned to but never used
691:9 local variable 'J20' is assigned to but never used
701:9 local variable 'genmat2' is assigned to but never used
719:9 local variable 'K20' is assigned to but never used

Je ne sais pas si c'est à corriger, ici ou ailleurs.

@fchapoton
Copy link
Contributor Author

comment:8

bah, à corriger ailleurs, je dirais

@vbraun
Copy link
Member

vbraun commented Jul 25, 2021

Changed branch from u/chapoton/31857 to 0554d48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants