Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translation of univariate Gamma from FriCAS #31858

Closed
mantepse opened this issue May 25, 2021 · 11 comments
Closed

Fix translation of univariate Gamma from FriCAS #31858

mantepse opened this issue May 25, 2021 · 11 comments

Comments

@mantepse
Copy link
Contributor

Before #25597 we had:

sage: fricas.Gamma(3/2).sage()
1/2*sqrt(pi)

but this is broken in Sage 9.3.

CC: @fchapoton @slel

Component: interfaces

Keywords: fricas

Author: Martin Rubey

Branch/Commit: bec32a1

Reviewer: Thierry Monteil

Issue created by migration from https://trac.sagemath.org/ticket/31858

@mantepse mantepse added this to the sage-9.4 milestone May 25, 2021
@mantepse
Copy link
Contributor Author

comment:1

The problem is that, in src/sage/functions/gamma.py, we have

        GinacFunction.__init__(self, 'gamma', latex_name=r"\Gamma",
                               ginac_name='gamma',
                               conversions={'mathematica':'Gamma',
                                            'maple':'GAMMA',
                                            'sympy':'gamma',
                                            'fricas':'Gamma',
                                            'giac':'Gamma'})

which attaches fricas.Gamma to the bivariate gamma function, not the symbolic function:

sage: lazy_import('sage.libs.pynac.pynac', ['symbol_table'])
sage: symbol_table["fricas"]["Gamma"].parent()
<class 'sage.functions.gamma.Function_gamma_inc'>
sage: gamma
<function gamma at 0x7ff1d6f2b940>

@mantepse
Copy link
Contributor Author

@mantepse
Copy link
Contributor Author

Commit: e785da4

@mantepse
Copy link
Contributor Author

New commits:

e785da4fix translation of Gamma

@mantepse
Copy link
Contributor Author

Author: Martin Rubey

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 25, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

bec32a1add classical doctest

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 25, 2021

Changed commit from e785da4 to bec32a1

@slel

This comment has been minimized.

@slel slel changed the title tranlation of univariate Gamma from fricas is broken Fix translation of univariate Gamma from FriCAS May 25, 2021
@sagetrac-tmonteil
Copy link
Mannequin

sagetrac-tmonteil mannequin commented May 25, 2021

Reviewer: Thierry Monteil

@sagetrac-tmonteil
Copy link
Mannequin

sagetrac-tmonteil mannequin commented May 25, 2021

comment:6

LGTM.

@vbraun
Copy link
Member

vbraun commented Jun 21, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants