Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 internet doctests failing in oeis.py #31866

Closed
seblabbe opened this issue May 27, 2021 · 7 comments
Closed

3 internet doctests failing in oeis.py #31866

seblabbe opened this issue May 27, 2021 · 7 comments

Comments

@seblabbe
Copy link
Contributor

The command

sage -t --optional=sage,internet src/sage/databases/oeis.py

gives

sage -t --long --warn-long 102.7 --random-seed=0 src/sage/databases/oeis.py
**********************************************************************
File "src/sage/databases/oeis.py", line 48, in sage.databases.oeis
Failed example:
    c.examples()                                  # optional -- internet
Expected:
    0: Pi = 3.1415926535897932384...
    1:    = 3 + 1/(7 + 1/(15 + 1/(1 + 1/(292 + ...))))
    2:    = [a_0; a_1, a_2, a_3, ...] = [3; 7, 15, 1, 292, ...]
Got:
    0: Pi = 3.1415926535897932384...
    1:    = 3 + 1/(7 + 1/(15 + 1/(1 + 1/(292 + ...))))
    2:    = [a_0; a_1, a_2, a_3, ...] = [3; 7, 15, 1, 292, ...].
**********************************************************************
File "src/sage/databases/oeis.py", line 53, in sage.databases.oeis
Failed example:
    c.comments()                                  # optional -- internet
Expected:
    0: The first 5821569425 terms were computed by _Eric W. Weisstein_ on Sep 18 2011.
    1: The first 10672905501 terms were computed by _Eric W. Weisstein_ on Jul 17 2013.
    2: The first 15000000000 terms were computed by _Eric W. Weisstein_ on Jul 27 2013.
Got:
    0: The first 5821569425 terms were computed by _Eric W. Weisstein_ on Sep 18 2011.
    1: The first 10672905501 terms were computed by _Eric W. Weisstein_ on Jul 17 2013.
    2: The first 15000000000 terms were computed by _Eric W. Weisstein_ on Jul 27 2013.
    3: The first 30113021586 terms were computed by _Syed Fahad_ on Apr 27 2021.
**********************************************************************
File "src/sage/databases/oeis.py", line 1706, in sage.databases.oeis.OEISSequence.examples
Failed example:
    c.examples()                          # optional -- internet
Expected:
    0: Pi = 3.1415926535897932384...
    1:    = 3 + 1/(7 + 1/(15 + 1/(1 + 1/(292 + ...))))
    2:    = [a_0; a_1, a_2, a_3, ...] = [3; 7, 15, 1, 292, ...]
Got:
    0: Pi = 3.1415926535897932384...
    1:    = 3 + 1/(7 + 1/(15 + 1/(1 + 1/(292 + ...))))
    2:    = [a_0; a_1, a_2, a_3, ...] = [3; 7, 15, 1, 292, ...].
**********************************************************************
2 items had failures:
   2 of  26 in sage.databases.oeis
   1 of   5 in sage.databases.oeis.OEISSequence.examples
    [290 tests, 3 failures, 40.15 s]
----------------------------------------------------------------------
sage -t --warn-long 102.8 --random-seed=0 src/sage/databases/oeis.py  # 3 doctests failed
----------------------------------------------------------------------

Notice the dot . added at the end of the first and third test.

Component: doctest coverage

Author: Sébastien Labbé

Branch/Commit: fd87c95

Reviewer: Thierry Monteil

Issue created by migration from https://trac.sagemath.org/ticket/31866

@seblabbe seblabbe added this to the sage-9.4 milestone May 27, 2021
@seblabbe
Copy link
Contributor Author

Commit: fd87c95

@seblabbe
Copy link
Contributor Author

Branch: u/slabbe/31866

@seblabbe
Copy link
Contributor Author

New commits:

fd87c9531866: fixing 3 doctests

@seblabbe
Copy link
Contributor Author

Author: Sébastien Labbé

@sagetrac-tmonteil
Copy link
Mannequin

sagetrac-tmonteil mannequin commented May 27, 2021

Reviewer: Thierry Monteil

@sagetrac-tmonteil
Copy link
Mannequin

sagetrac-tmonteil mannequin commented May 27, 2021

comment:3

LGTM.

@vbraun
Copy link
Member

vbraun commented Jun 21, 2021

Changed branch from u/slabbe/31866 to fd87c95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants