Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RealSet: Replace is_included_in, is_disjoint_from by is_subset, is_disjoint #31927

Closed
mkoeppe opened this issue Jun 7, 2021 · 16 comments
Closed

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jun 7, 2021

is_included_in is only defined by RealSet. We deprecate it and replace it by is_subset.

The spelling issubset is used in Python sets. is_subset is widely used in Sage. Sympy provides both spellings (see #31926), but the source code notes that issubset "should be deprecated".

Depends on #21243

CC: @tscrim @mjungmath

Component: geometry

Author: Matthias Koeppe

Branch/Commit: f27026f

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/31927

@mkoeppe mkoeppe added this to the sage-9.4 milestone Jun 7, 2021
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 9, 2021

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 9, 2021

Commit: 9079a10

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 9, 2021

New commits:

9079a10RealSet.is_subset: Rename from is_included_in

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 9, 2021

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title RealSet: Replace is_included_in by is_subset / issubset RealSet: Replace is_included_in by is_subset Jun 9, 2021
@mkoeppe mkoeppe changed the title RealSet: Replace is_included_in by is_subset RealSet: Replace is_included_in, is_disjoint_from by is_subset, is_disjoint Jun 9, 2021
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 9, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

5b8cecaInternalRealInterval, RealSet: Add `_latex_` methods
69ca854RealSet._repr_: Use unicode cup sign instead of +
dbdfc06InternalRealInterval, RealSet: Remove extra whitespace in latex, add documentation
a0e3bf5Merge #31880
181b128RealSet.is_open, is_closed, closure, interior, boundary: New
7f56338PiecewiseFunction: Adjust doctests for changed RealSet repr
8cd74b5Merge #31880
8fdb104RealSet.boundary: Add another doctest
0a2f499Merge #21243
4bc5a2cRealSet.is_disjoint: Rename from is_disjoint_from

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 9, 2021

Changed commit from 9079a10 to 4bc5a2c

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 9, 2021

Dependencies: #21243

@tscrim
Copy link
Collaborator

tscrim commented Jun 9, 2021

comment:8

LGTM.

Can you also open a followup ticket (or on the original tickets or here) some quick fixes of some little things I missed during my previous reviews (sorry!):

@tscrim
Copy link
Collaborator

tscrim commented Jun 9, 2021

Reviewer: Travis Scrimshaw

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 10, 2021

comment:9

Thanks! I have updated these tickets.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 10, 2021

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

9d41f0esrc/sage/sets/real_set.py: Remove unnecessary import
f27026fMerge #21243

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 10, 2021

Changed commit from 4bc5a2c to f27026f

@tscrim
Copy link
Collaborator

tscrim commented Jun 10, 2021

comment:12

Thank you.

@vbraun
Copy link
Member

vbraun commented Jun 29, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants