-
-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RealSet: Replace is_included_in, is_disjoint_from by is_subset, is_disjoint #31927
Comments
This comment has been minimized.
This comment has been minimized.
Commit: |
New commits:
|
Author: Matthias Koeppe |
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
Dependencies: #21243 |
comment:8
LGTM. Can you also open a followup ticket (or on the original tickets or here) some quick fixes of some little things I missed during my previous reviews (sorry!):
|
Reviewer: Travis Scrimshaw |
comment:9
Thanks! I have updated these tickets. |
comment:12
Thank you. |
Changed branch from u/mkoeppe/realset__replace_is_included_in_by_is_subset___issubset to |
is_included_in
is only defined byRealSet
. We deprecate it and replace it byis_subset
.The spelling
issubset
is used in Python sets.is_subset
is widely used in Sage. Sympy provides both spellings (see #31926), but the source code notes thatissubset
"should be deprecated".Depends on #21243
CC: @tscrim @mjungmath
Component: geometry
Author: Matthias Koeppe
Branch/Commit:
f27026f
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/31927
The text was updated successfully, but these errors were encountered: