Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper class for Sage sets as SymPy sets #31938

Closed
mkoeppe opened this issue Jun 9, 2021 · 19 comments
Closed

Wrapper class for Sage sets as SymPy sets #31938

mkoeppe opened this issue Jun 9, 2021 · 19 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jun 9, 2021

We add a _sympy_ method to all sets. It creates an instance of the new class sage.interfaces.sympy_wrapper.SageSet, which is a subclass of SymPy's Set class.

Part of Meta-ticket #31926: Connect Sage sets to sympy sets

CC: @kcrisman @tscrim

Component: interfaces

Author: Matthias Koeppe

Branch/Commit: c06c965

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/31938

@mkoeppe mkoeppe added this to the sage-9.4 milestone Jun 9, 2021
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 9, 2021

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 9, 2021

comment:3

Here's a beginning. This obviously needs many more examples/tests


New commits:

6e5cac6sage.interfaces.sympy_wrapper, Sets.ParentMethods._sympy_: New

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 9, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 9, 2021

Commit: 6e5cac6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 9, 2021

Changed commit from 6e5cac6 to 3cac256

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 9, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

3cac256sage.interfaces.sympy_wrapper: Add doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 9, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

eef604eSageSet: Finish docstrings; handle symbolic _contains

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 9, 2021

Changed commit from 3cac256 to eef604e

@mkoeppe

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 9, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

2baae58Sets.ParentMethods._sympy_: Call sympy_init

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 9, 2021

Changed commit from eef604e to 2baae58

@tscrim
Copy link
Collaborator

tscrim commented Jun 9, 2021

comment:8

I know it is not so useful, but please add a doctest for __new__. Perhaps running a TestSuite? Other than that, LGTM assume a green bot.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 10, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

c06c965sage.interfaces.sympy_wrapper.SageSet: Add another doctest

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 10, 2021

Changed commit from 2baae58 to c06c965

@tscrim
Copy link
Collaborator

tscrim commented Jun 10, 2021

comment:10

Thank you. Now once the bot comes back green, positive review.

@tscrim
Copy link
Collaborator

tscrim commented Jun 10, 2021

Reviewer: Travis Scrimshaw

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 11, 2021

comment:13

Thanks!

@vbraun
Copy link
Member

vbraun commented Jun 29, 2021

Changed branch from u/mkoeppe/wrapper_class_for_sage_sets_as_sympy_sets to c06c965

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants