Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finite dimensional invariant algebra #31939

Closed
trevorkarn opened this issue Jun 9, 2021 · 37 comments
Closed

Finite dimensional invariant algebra #31939

trevorkarn opened this issue Jun 9, 2021 · 37 comments

Comments

@trevorkarn
Copy link
Contributor

As part of the GSoC project #31929, we will implement a class for invariant algebras, given a group action on the basis of an algebra.

Depends on #31987

CC: @tscrim @trevorkarn

Component: algebra

Keywords: gsoc2021 invariant

Author: Trevor K. Karn

Branch/Commit: 2a64c19

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/31939

@trevorkarn trevorkarn added this to the sage-9.4 milestone Jun 9, 2021
@trevorkarn
Copy link
Contributor Author

New commits:

35f43f3Initial commit
5526500Add `__init__` and tests

@trevorkarn
Copy link
Contributor Author

Commit: 5526500

@trevorkarn
Copy link
Contributor Author

Branch: u/tkarn/invariant_modules_31939

@trevorkarn trevorkarn self-assigned this Jun 9, 2021
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 11, 2021

Changed commit from 5526500 to c8b769b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 11, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

466a9bcAdd .invariant_algebra() method to ParentMethods of FiniteDimensionalModuleWithBasis
c8b769bRewrite FiniteDimensionalInvariantAlgebra to subclass UniqueRepresentation and SubmoduleWithBasis

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 15, 2021

Changed commit from c8b769b to 3c2a2f9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 15, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

c1bafa5Fix bad merge
775fae7Remove @cached_method decorator from .invariant_algebra()
842b314Move from algebras.invariants to modules.with_basis.invariant
37dafe9WIP
3c2a2f9Add FiniteDiimensionalInvariantModule with no tests/documentation

@trevorkarn
Copy link
Contributor Author

Dependencies: #31987

@trevorkarn
Copy link
Contributor Author

Changed keywords from gsoc invariant to gsoc2021 invariant

@trevorkarn

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 21, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

f0cadccFix typos and whitespace issues
263b385Initial commit of FiniteDimensionalTwistedInvariantModule
e767248Fix multiplication and add tests
374207fFix cyclic action on generators of ExteriorAlgebra, add tests for the multiplication of group elements on the group algebra as a representation
7e423f8Merge branch 'catrep' into invariants
5351ebbFix PEP8 spacing issue, simplify tuple
469286cMerge branch 'catrep' into invariants
dc9a3d0Fix whitespace issues
81f3bc4Add tests and `_repr_` to finite_dimensional_invariant_algebras
beeda87WIP

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 21, 2021

Changed commit from 3c2a2f9 to beeda87

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 21, 2021

Changed commit from beeda87 to 7cf2cf0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 21, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

7cf2cf0WIP

@trevorkarn

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 22, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a70d92cWIP
3748265Remove invariant algebra class
e981555Remove OS changes
e0712a4Modify invariant.py to work only in the Representation (not in the ambient module of the Representation)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 22, 2021

Changed commit from 7cf2cf0 to e0712a4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 23, 2021

Changed commit from e0712a4 to 2c6ada7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 23, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

2c6ada7Add tests for arithmetic in FiniteDimensionalInvariantModule, fix bug with multiplication of the underlying representation's underlying module's base ring

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 25, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

f08d6f9Add tests to invariant.py for full coverage
a5fab0cFix error introduced in representation.py
ff2047dAdd reference for invariants/twisted invariants
a15d52eWIP
d2d1ddeAdd check for valid characters for finite semigroups
d89c264Add basis computation and initial commit of Element class

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 25, 2021

Changed commit from 2c6ada7 to d89c264

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 6, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

730baaeAdd tests and `_repr_` to finite_dimensional_invariant_algebras
f4d5ed6WIP
6ae01b4Remove invariant algebra class
63ddf15Remove OS changes
f93c224Modify invariant.py to work only in the Representation (not in the ambient module of the Representation)
1c87493Add tests for arithmetic in FiniteDimensionalInvariantModule, fix bug with multiplication of the underlying representation's underlying module's base ring
1792be1Add tests to invariant.py for full coverage
d5bb24cRemove draft of twisted invariant. Moved to trac #32145
f121263Fix whitespace
f519fbcAdd _test_invariant for TestSuite

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 6, 2021

Changed commit from d89c264 to f519fbc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 8, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

3519cf1Add _test_invariant for TestSuite
0b000e1Add exposition to examples of invariant.py
f6f76c5Fix invariant_module method inside the FiniteDimensionalModuleWithBasis.ParentMethods class
ac750a4Add example of symmetric functions with monomial basis
42d5e34Fix `_mul_` to assume that both are in same parent
c038ef5Edit exposition in symmetric function example

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 8, 2021

Changed commit from f519fbc to c038ef5

@trevorkarn
Copy link
Contributor Author

comment:18

It was suggested to change the FiniteDimensionalInvariantModule._semigroup_representation attribute to be an alias of FiniteDimensionalInvariantModule._ambient. I chose not to use this suggestion because the semigroup representation is required to build the basis which we use to call the SubmoduleWithBasis.__init__ via super(), but the ._ambient attribute is defined in SubmoduleWithBasiis.__init__, so it seemed circular.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 8, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

a75293aAdd exposition in examples

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 8, 2021

Changed commit from c038ef5 to a75293a

@tscrim
Copy link
Collaborator

tscrim commented Jul 9, 2021

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jul 9, 2021

@tscrim
Copy link
Collaborator

tscrim commented Jul 9, 2021

Changed commit from a75293a to 553dc56

@tscrim
Copy link
Collaborator

tscrim commented Jul 9, 2021

comment:20

Thank you. I have made my reviewer pass through the code. Overall it looks great. However, I thought some more about what type of constructions we want it to handle. As a result, I made what the invariant module can handle much more general. This allows us to use a natural action, should it exist, or pass a general action (not necessarily one defined on the basis).

In order to make things work smoothly, I had to extend some stuff for Representation so it more naturally works with subgroups and coercion. I also removed the _l/rmul_ as those are generically implemented in the IndexedModuleElement class (I forgot about this; sorry!). I did some other documentation tweaks.

If my changes are good with you, then you can set a positive review.


New commits:

553dc56Reviewer changes for invariant modules.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 9, 2021

Changed commit from 553dc56 to 2a64c19

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 9, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

2a64c19Update input documentation

@trevorkarn
Copy link
Contributor Author

comment:22

The changes made before commit 2a64c19 look good to me. If the changes to the documentation I made are good, then you can set a positive review.

@tscrim
Copy link
Collaborator

tscrim commented Jul 9, 2021

comment:23

Thanks.

@vbraun
Copy link
Member

vbraun commented Jul 23, 2021

Changed branch from public/algebras/invariant_modules-31939 to 2a64c19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants