Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rst2ipynb: Remove patches after update to 0.2.3 #31967

Closed
mkoeppe opened this issue Jun 12, 2021 · 22 comments
Closed

rst2ipynb: Remove patches after update to 0.2.3 #31967

mkoeppe opened this issue Jun 12, 2021 · 22 comments
Labels
c: packages: optional r: duplicate t: enhancement

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jun 12, 2021

(from #31543)

The updated was done in #31280, but patches were not removed, so it is broken.

Depends on #31280

CC: @dimpase

Component: packages: optional

Branch/Commit: u/mkoeppe/rst2ipynb__remove_patches_after_update_to_0_2_3 @ bc7679d

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/31967
@mkoeppe mkoeppe added this to the sage-9.4 milestone Jun 12, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 12, 2021

Branch: u/mkoeppe/rst2ipynb__update_to_0_2_3_to_remove_patching

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 12, 2021

Commit: f263d6f

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 12, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 12, 2021

New commits:

f263d6fbuild/pkgs/rst2ipynb: Update to 0.2.3 to remove patching

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 12, 2021

Changed branch from u/mkoeppe/rst2ipynb__update_to_0_2_3_to_remove_patching to none

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 12, 2021

Changed commit from f263d6f to none

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 12, 2021

Changed author from Matthias Koeppe to none

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 12, 2021

comment:3

Actually did this already in #31280

@mkoeppe mkoeppe removed this from the sage-9.4 milestone Jun 12, 2021
@slel
Copy link
Member

slel commented Jun 13, 2021

Reviewer: Matthias Koeppe

@slel

This comment has been minimized.

Sign in to view
@fchapoton
Copy link
Contributor

comment:5

patches were not removed in #31280

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 25, 2021

Changed reviewer from Matthias Koeppe to none

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 25, 2021

Dependencies: #31280

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 25, 2021

comment:6

Indeed. I'll fix it here because #31280 is already on Volker's branch

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 25, 2021

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe mkoeppe changed the title rst2ipynb: Update to 0.2.3 to remove patching rst2ipynb: Remove patches after update to 0.2.3 Jun 25, 2021
@mkoeppe mkoeppe added this to the sage-9.4 milestone Jun 25, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 25, 2021

Branch: u/mkoeppe/rst2ipynb__remove_patches_after_update_to_0_2_3

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 25, 2021

Commit: bc7679d

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 25, 2021

Last 10 new commits:

7c94735build/pkgs/pandocfilters/checksums.ini: Add upstream_url
6079a11build/pkgs/ptyprocess/checksums.ini: Add upstream_url
2694cbfbuild/pkgs/requests/checksums.ini: Add upstream_url
62769f9build/pkgs/rst2ipynb/checksums.ini: Add upstream_url
eb6d3d0build/pkgs/scandir/checksums.ini: Add upstream_url
e2cada9build/pkgs/snowballstemmer/checksums.ini: Add upstream_url
d83e2f8build/pkgs/wcwidth/checksums.ini: Add upstream_url
c943913build/pkgs/{backcall,ptyprocess}/dependencies: flit_core switched from pytoml to toml; remove pytoml package
8ea1b57Merge branch 'u/mkoeppe/jupyter_upgrade' of git://trac.sagemath.org/sage into t/31967/rst2ipynb__remove_patches_after_update_to_0_2_3
bc7679dbuild/pkgs/rst2ipynb/patches: Remove

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 6, 2021

Changed author from Matthias Koeppe to none

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 6, 2021

comment:11

As #31280 came back with needs_work, I have put the commit on the branch there.

We can close the present ticket.

@mkoeppe mkoeppe removed this from the sage-9.4 milestone Jul 6, 2021
@dimpase
Copy link
Member

dimpase commented Jul 7, 2021

Reviewer: Dima Pasechnik

@mkoeppe mkoeppe mentioned this issue Jan 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: optional r: duplicate t: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dimpase @slel @fchapoton @mkoeppe