Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiplier Spectra for P^N, N > 1 #32035

Closed
EnderWannabe opened this issue Jun 22, 2021 · 29 comments
Closed

Multiplier Spectra for P^N, N > 1 #32035

EnderWannabe opened this issue Jun 22, 2021 · 29 comments
Labels
c: dynamics p: minor / 4 t: enhancement
Milestone
sage-9.8

Comments

@EnderWannabe
Copy link
Contributor

Currently the multiplier spectra function for dynamical systems on PN throws a NotImplementedError when N > 1.

This ticket aims to implement that functionality.

Depends on #31944
Depends on #32041

CC: @bhutz

Component: dynamics

Keywords: gsoc2021

Author: Alexander Galarraga

Branch/Commit: 4a0e9a1

Reviewer: Ben Hutz

Issue created by migration from https://trac.sagemath.org/ticket/32035
@EnderWannabe EnderWannabe added this to the sage-9.4 milestone Jun 22, 2021
@EnderWannabe

This comment has been minimized.

Sign in to view
@EnderWannabe
Copy link
Contributor Author

Branch: u/gh-EnderWannabe/multiplier_spectra

@EnderWannabe
Copy link
Contributor Author

Last 10 new commits:

27888da31954: initial commit with working code and examples
22201d7Merge branch 'hyperplane_transform' into periodic_points_improvement
c32484431944: added computation for formal periodic points
91ebb2231944: removed changes in tickets 31906 and 31896 from this ticket
df038ca31944: initial formal preperiodic points
5d142bf31944: examples for formal preperiodic points, fixed return scheme for formal preperiodic points
d4957f4Merge branch 'u/gh-EnderWannabe/periodic_points_improvement' of trac.sagemath.org:sage into multiplier_spectra
254b1a8working on number fields
ab0b37cMerge branch 'develop' into multiplier_spectra
d23769a32035: added tests, functionality for QQbar and algebraic closures of finite fields

@EnderWannabe
Copy link
Contributor Author

Changed dependencies from 31944 to #31944

@EnderWannabe
Copy link
Contributor Author

Commit: d23769a

@EnderWannabe
Copy link
Contributor Author

Changed dependencies from #31944 to #31944, #32041

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 23, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

9a2c01c32041: added fix and test
0903a77Merge branch 'reduced_form_fix' into multiplier_spectra
558c25532035: cleaned up code, added documentation
dbbd3dc32035: added test for algebraic closure

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 23, 2021

Changed commit from d23769a to dbbd3dc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 24, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

083b6fa32035: minor code cleanup
2f064fd32035: added comments, fixed output documentation

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 24, 2021

Changed commit from dbbd3dc to 2f064fd

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 7, 2021

Changed commit from 2f064fd to 732b08a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 7, 2021

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

b4ec7c131944: minor fixes
6b810a231944: fixed periodic typo and added test
b8ce4b731906: actual fix for warning message
dc36d19Merge branch 'u/gh-EnderWannabe/point_matrix_improvement' of trac.sagemath.org:sage into point_transformation_improvement
e7e893031906: fixed denominator bug
e49e34cMerge branch 'point_transformation_improvement' into periodic_points_improvement
3a04a8d31944: fixed bug with formal=True over ring
4a62742Merge branch 'develop' into periodic_points_improvement
e3693f031944: added error message for fraction fields of m polynomial rings
732b08aMerge branch 'periodic_points_improvement' into multiplier_spectra

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 12, 2021

Changed commit from 732b08a to 27de53e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 12, 2021

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

b82de34Merge branch 'u/gh-EnderWannabe/hyperplane_transform' of trac.sagemath.org:sage into hyperplane_transform
379a732Merge branch 'hyperplane_transform' into affine_preperiodic
15f206c32166: fixed typos, added subscheme example
b4246d232166: fixed identity matrix return
eaebd3332166: added test for identity
57a4b39Merge branch 'affine_preperiodic' into periodic_points_improvement
81d7c9732166: fixed documentation
a63927eMerge branch 'affine_preperiodic' into periodic_points_improvement
9b5e74f31944: fixed calls to affine preperiodic model
27de53eMerge branch 'periodic_points_improvement' into multiplier_spectra

@bhutz
Copy link

bhutz commented Jul 20, 2021

Reviewer: Ben Hutz

@bhutz
Copy link

bhutz commented Jul 20, 2021

comment:10

I see no issues with functionality. A few minor doc things and one extra if.

  • the default is formal=False, so the first main paragraph should not say it computes the formal unless the user specifies otherwise (i.e., that logic should be reversed)

  • end of second paragraph - "critical points" should be "periodic points"

  • If False, and he map is -> "the"

  • use_algebraic_closure - "critical points" should be "periodic points"

  • no examples of algebraic closures in dimension > 1

  • line 4711 -- need line wrap

  • line 4798 -- extra word in comment ("which point the point")

  • line 4817 -- aren't we already in the dimension == 1 case?

  • looks like this needs to be updated for the latest preperiodic point ticket (31944)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 20, 2021

Changed commit from 27de53e to 2ab4ac6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 20, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

b695b25Merge branch 'u/gh-EnderWannabe/multiplier_spectra' of git://trac.sagemath.org/sage into multiplier_spectra
f1e195831944: fix for subscheme issue
d3ea2be31944: added check for morphisms
268bc8331944: fixed if statement
6f2857f31944: added example for formal preperiodic
8827e74Merge branch 'u/gh-EnderWannabe/periodic_points_improvement' of git://trac.sagemath.org/sage into periodic_points_improvement
c35b14aMerge branch 'periodic_points_improvement' into multiplier_spectra
2ab4ac632035: doc fixes

@bhutz
Copy link

bhutz commented Jul 22, 2021

Changed branch from u/gh-EnderWannabe/multiplier_spectra to u/bhutz/multiplier_spectra

@bhutz
Copy link

bhutz commented Jul 22, 2021

comment:14

The commit fixed a couple of the missed doc issues, but the use_algebraic_closure example is still an issue and exposes an problem. If you only use the base_field when it is false you are missing periodic points and hence not returning the full multiplier spectrum.

One option is to count the number of points you have (with multiplicity) and throw an error if the base field doesn't contain them all.

New commits:

25b19e232035: minor doc fixes

@bhutz
Copy link

bhutz commented Jul 22, 2021

Changed commit from 2ab4ac6 to 25b19e2

@EnderWannabe
Copy link
Contributor Author

Changed branch from u/bhutz/multiplier_spectra to u/gh-EnderWannabe/multiplier_spectra

@EnderWannabe
Copy link
Contributor Author

comment:16

Replying to @bhutz:

One option is to count the number of points you have (with multiplicity) and throw an error if the base field doesn't contain them all.

Good catch. Added such a check.

New commits:

5fcf96d32035: added check for if the full spectra was computed

@EnderWannabe
Copy link
Contributor Author

Changed commit from 25b19e2 to 5fcf96d

@vbraun
Copy link
Member

vbraun commented Jul 25, 2021

comment:19

Merge conflict

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Aug 9, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 18, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 2, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Sep 19, 2022
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 22, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

4a0e9a1Merge branch 'u/gh-EnderWannabe/multiplier_spectra' of trac.sagemath.org:sage into 32035

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 22, 2022

Changed commit from 5fcf96d to 4a0e9a1

@bhutz
Copy link

bhutz commented Oct 20, 2022

comment:26

The merge conflict resolution looks ok with all tests passing.

@vbraun
Copy link
Member

vbraun commented Oct 23, 2022

Changed branch from u/gh-EnderWannabe/multiplier_spectra to 4a0e9a1

@vbraun vbraun closed this as completed in d8bc405 Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: dynamics p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
4 participants
@vbraun @mkoeppe @bhutz @EnderWannabe