Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ubuntu-trusty: Fix eclib build failure #32101

Closed
mkoeppe opened this issue Jul 2, 2021 · 9 comments
Closed

ubuntu-trusty: Fix eclib build failure #32101

mkoeppe opened this issue Jul 2, 2021 · 9 comments
Labels
c: packages: standard p: blocker / 1 t: bug
Milestone
sage-9.4

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jul 2, 2021

(from #31443 comment:124)

CC: @JohnCremona @dimpase

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: d1c6ace

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/32101
@mkoeppe mkoeppe added this to the sage-9.4 milestone Jul 2, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 2, 2021

Branch: u/mkoeppe/ubuntu_trusty__fix_eclib_build_failure

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 2, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 2, 2021

New commits:

d1c6acebuild/pkgs/eclib/patches/points_const.patch: New

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 2, 2021

Commit: d1c6ace

@dimpase
Copy link
Member

dimpase commented Jul 3, 2021

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Jul 3, 2021

comment:3

lgtm

@JohnCremona
Copy link
Member

comment:4

Thanks for dealing with this. The change has been made to eclib, so the patch will only be needed until the next eclib release.

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 3, 2021

comment:5

Thanks!

@vbraun
Copy link
Member

vbraun commented Jul 9, 2021

Changed branch from u/mkoeppe/ubuntu_trusty__fix_eclib_build_failure to d1c6ace

@vbraun vbraun closed this as completed in 3dadb86 Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: blocker / 1 t: bug
Projects
None yet
Milestone
sage-9.4
Development

No branches or pull requests
4 participants
@vbraun @dimpase @JohnCremona @mkoeppe