Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PolyhedronRepresentation: Add subclasses StrictInequality, StrictRay #32159

Open
mkoeppe opened this issue Jul 8, 2021 · 21 comments
Open

PolyhedronRepresentation: Add subclasses StrictInequality, StrictRay #32159

mkoeppe opened this issue Jul 8, 2021 · 21 comments
Labels
c: geometry p: major / 3 s: needs work t: enhancement

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jul 8, 2021

This is preparation for #34327 (ConvexVPolyhedralSet_base, ConvexHPolyhedralSet_base)

CC: @kliem @kcrisman

Component: geometry

Work Issues: add StrictRay

Author: Matthias Koeppe

Branch/Commit: u/mkoeppe/polyhedronrepresentation__add_subclass_strictinequality @ c97760f

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/32159
@mkoeppe mkoeppe added this to the sage-9.4 milestone Jul 8, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 8, 2021

Branch: u/mkoeppe/polyhedronrepresentation__add_subclass_strictinequality

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 8, 2021

Commit: 5cb0e3f

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 8, 2021

New commits:

5cb0e3fsage.geometry.polyhedron.representation.StrictInequality: New

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 8, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 19, 2021

comment:3

Setting a new milestone for this ticket based on a cursory review.

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 18, 2021

comment:4

Stalled in needs_review or needs_info; likely won't make it into Sage 9.5.

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 18, 2021
@videlec
Copy link
Contributor

videlec commented Dec 29, 2021

Reviewer: Vincent Delecroix

@videlec
Copy link
Contributor

videlec commented Dec 29, 2021

comment:5

Does the provided code is enough to define a polyhedron with both strict and non-strict inequalities? It seems weird to introduce this class and not being able to use it.

@mkoeppe
Copy link
Member Author

mkoeppe commented Dec 29, 2021

comment:6

Not by itself, no, which is why the lines marked # temporary workaround in the doctests are necessary.

@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 2, 2022
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe mkoeppe changed the title PolyhedronRepresentation: Add subclass StrictInequality PolyhedronRepresentation: Add subclasses StrictInequality, StrictRay Aug 9, 2022
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 9, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

30b6481sage.geometry.polyhedron.representation.StrictInequality: New

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 9, 2022

Changed commit from 5cb0e3f to 30b6481

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 9, 2022

Work Issues: add StrictRay

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 10, 2022

Changed commit from 30b6481 to 0f5da27

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 10, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

0f5da27src/sage/geometry/polyhedron/representation.py (StrictRay): New

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 10, 2022

Changed commit from 0f5da27 to f79f054

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 10, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

58062a8src/sage/geometry/polyhedron/{parent,representation}.py: Update copyright according to git blame -w --date=format:%Y FILE | sort -k2
f79f054src/sage/geometry/polyhedron/parent.py (Polyhedra_base): Add _make_StrictInequality, _make_StrictRay methods

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 10, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

2621322src/sage/geometry/polyhedron/representation.py: Update doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 10, 2022

Changed commit from f79f054 to 2621322

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 10, 2022

Changed commit from 2621322 to c97760f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 10, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

c97760fsrc/sage/geometry/polyhedron/parent.py: fixup

@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Dec 31, 2022
This was referenced Jan 29, 2023
Open
Open
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 s: needs work t: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@videlec @mkoeppe