kRegularSequenceSpace.from_recurrence: make offset keyword-only

[galipnik]

In view of #31787, offset should be a keyword-only argument of kRegularSequenceSpace.from_recurrence and RecurrenceParser.__call__.

Depends on #27940

CC: @cheuberg @dkrenn

Component: combinatorics

Author: Gabriel F. Lipnik

Branch/Commit: 72bd352

Reviewer: Clemens Heuberger, Daniel Krenn

Issue created by migration from https://trac.sagemath.org/ticket/32198

[galipnik]

Branch: u/galipnik/k-regular-offset

[sagetrac-git]

Commit: dd8b09f

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

22cb3f0	Trac #27940: remove underscores from helper methods
293905a	Trac #27940: remove "_from_recurrence" from method names
75fe130	Trac #27940: remove "get_" from method names
952d724	Trac #27940: consistently use coefficient_ring
fbf3a81	Trac #27940: adapt/complete docstrings
16de2ab	Trac #27940: unify input parameters
86c5df7	Trac #27940: fix indention (due to renamings)
6db5f58	Trac #27940 review 67: change signature of output of RecurrenceParser.__call__
488123c	Trac #27940: remove redundant line
dd8b09f	Trac #32198: make offset keyword-only

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

c64cd60

Trac #32198: mention positional and keyword-only arguments in docstring

[sagetrac-git]

Changed commit from dd8b09f to c64cd60

[cheuberg]

Reviewer: Clemens Heuberger

[cheuberg]

comment:6

LGTM. Let us wait a few days to give dkrenn a chance to have a look on it and then feel free to set to positive unless dkrenn objects.

[dkrenn]

comment:7

Why do we need make offset explicit in

-    def from_recurrence(self, *args, **kwds):
+    def from_recurrence(self, *args, offset=0):

? Shouldn't it suffices (as done) in

+    def __call__(self, *args, offset=0):

Apart from this, changes LGTM

[dkrenn]

Changed reviewer from Clemens Heuberger to Clemens Heuberger, Daniel Krenn

[dkrenn]

comment:10

Replying to @dkrenn:

Why do we need make offset explicit in

-    def from_recurrence(self, *args, **kwds):
+    def from_recurrence(self, *args, offset=0):

?

Briefly tested using **kwds (on #31787); seems to work.

[mkoeppe]

comment:11

Setting a new milestone for this ticket based on a cursory review.

[dkrenn]

Changed branch from u/galipnik/k-regular-offset to u/dkrenn/k-regular-offset

[dkrenn]

comment:13

Replying to @dkrenn:

Replying to @dkrenn:

Why do we need make offset explicit in

-    def from_recurrence(self, *args, **kwds):
+    def from_recurrence(self, *args, offset=0):

?

Briefly tested using **kwds (on #31787); seems to work.

Changed.

---

New commits:

72bd352

Trac #32198: pass on all kwds (instead of "offset" explicitly)

[dkrenn]

Changed commit from c64cd60 to 72bd352

[galipnik]

comment:16

Replying to @dkrenn:

Changed.

Thank you, commit 72bd352 LGTM.

[dkrenn]

comment:17

Patchbot is happy :)

[cheuberg]

comment:18

commit 72bd352 LGTM.

[slel]

comment:19

Setting to critical in view of

• https://groups.google.com/g/sage-release/c/c7Dntbmyep0/m/_rRUkrNyBQAJ

[vbraun]

Changed branch from u/dkrenn/k-regular-offset to 72bd352