notebook -- it is now broken on the iphone

[williamstein]

Now I think left or right parenthesis sends carriage return. I think this likely has something to do with updating the keyboard support for the new safari browser.

Component: notebook

Issue created by migration from https://trac.sagemath.org/ticket/3223

[williamstein]

Attachment: sage-3223.patch.gz

[williamstein]

comment:1

I fixed this by disabling all keyboard shortcut handling on the iphone. This is a good idea, since the iphone does not have any of the keys needed to send any of the keyboard shortcuts, and it gets around the problem.

To referee this 3-line patch, just verify that clearly I didn't break anything, since all I did was add a special case to check for the iphone string in the browser UA tag, and only then disable keyboard shortcut handling.

[williamstein]

comment:2

I'm moving this back to 3.2. It's harmless (famous last words), and I really think having iphone support working again is an extremely important bug fix.

[boothby]

comment:3

+1

[sagetrac-mabshoff]

comment:5

Merged in Sage 3.2.rc2