Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments for the 2-adic lseries of elliptic curves #32258

Closed
chriswuthrich opened this issue Jul 21, 2021 · 15 comments
Closed

Adjustments for the 2-adic lseries of elliptic curves #32258

chriswuthrich opened this issue Jul 21, 2021 · 15 comments

Comments

@chriswuthrich
Copy link
Contributor

This is a minor bug that I am sure to be the first one to notice. Currently one cannot evaluate the (unique) Teichmuller twist of the 2-adic L-series of an elliptic curve. Furthermore the odd powers of the Teichmuller twists are incorrectly normalised. This is harmless except for p=2.

CC: @loefflerd

Component: elliptic curves

Keywords: p-adic L-series

Author: Chris Wuthrich

Branch: 7b7f6ad

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/32258

@chriswuthrich
Copy link
Contributor Author

comment:1

Expect a correction soon.

@chriswuthrich
Copy link
Contributor Author

Commit: f073844

@chriswuthrich
Copy link
Contributor Author

comment:2

But I couldn't do any testing yet or adjusting doctests.


New commits:

f073844adjust 2-adic lseries for elliptic curves

@chriswuthrich
Copy link
Contributor Author

Branch: u/wuthrich/ticket_32258

@chriswuthrich
Copy link
Contributor Author

Author: Chris Wuthrich

@chriswuthrich
Copy link
Contributor Author

comment:3

I will record here, why the change in the normalisation of the odd powers of the Teichmüller twists are now correct.

Suppose E has good ordinary reduction at p. Let L_p(E) be the p-adic L-series of E as sage returns it. If p=2 or p%4 = 1, then the p-adic L-series twisted by the (p-1)/2-th power of the Teichmüller corresponds to the twist by the quadratic character chi by -1 or -p respectively. Let L_p(E,chi) to be this p-adic L-series returned by taking eta=1 or eta=(p-1)/2 respectively. The constant term of L_p(E,chi) is equal to 1/alpha^u * L(E,chi,1) * Gausssum(chi)/ Omega_minus with u=2 if p=2 and u=1 if p>2. The question is now why is Omega_minus equal to the smallest positive multiple of i that is in the period lattice of E.

The main conjecture says that L_p(E) and the twisted L_p(E,chi) are the characteristic series of Selmer groups. Greenberg has calculated the constant term even in the case p=2. Suppose E has rank 0 over K = Q(i) or K = Q(sqrt(-p) respectively. The main conjecture now predict L_p(E)(0) * L_p(E,chi)(0) and (1-1/alpha)^2 * 1/alpha^u * prod c_v(E/K) * |Sha(E/K)|/ |E(K)|^2, where the product runs over all FINITE Tamagawa numbers, have the same p-adic valuation. The p-adic BSD of E/K predicts the equality of these two p-adic numbers.

The following function should therefore return a p-adic approximation of a power of 4 if the conditions above are satisfied.

def ch(E,p):
    """
    check curve E at p,
    should return a power of 4.

    EXAMPLE::

        sage: ch(EllipticCurve("443c1"), 13)
        1 + O(13^5)
        sage: ch(EllipticCurve("443c1"), 2)
        2^2 + O(2^8)

    """
    if p == 2:
        u = 2
        D = -1
        po = 1
        k = 8
    else:
        u = 1
        D = -p
        po = (p-1)//2
        k = 4 if p<6 else 3

    lp = E.padic_lseries(p,implementation="num")
    l0 = lp.series(k, prec=3)
    l1 = lp.series(k, eta = po, prec=3)
    ct = l0.list()[0] * l1.list()[0]

    al = lp.alpha()
    eps = (1-1/al)**2 * 1/al**u

    K = QuadraticField(D)
    EK = E.base_extend(K)
    Ed = E.quadratic_twist(D)
    tam = EK.tamagawa_product()
    sh = E.sha().an() * Ed.sha().an() # that is not SHA/K because of 2-torsion.
    tor = EK.torsion_order()
    return ct/eps/tam/sh*tor**2

... and I have checked it on quite a number of curves with both rectamgular and non-rectangular period lattice.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 24, 2021

Changed commit from f073844 to 5620235

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 24, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

5620235trac 32258: add doctest

@fchapoton
Copy link
Contributor

comment:7

there is a typo in "charachters"

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 21, 2021

Changed commit from 5620235 to 7b7f6ad

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 21, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

b859fd6Merge branch 'develop' of git://github.com/sagemath/sage into twoadiclseries
7b7f6adtrac 32258: typos

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:9

I will assume that the math is correct => positive review.

@vbraun
Copy link
Member

vbraun commented Oct 19, 2021

Changed branch from u/wuthrich/ticket_32258 to 7b7f6ad

@fchapoton
Copy link
Contributor

Changed commit from 7b7f6ad to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants