Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isogenies prime degree fails on some CM curves #32269

Closed
sachihashimoto mannequin opened this issue Jul 23, 2021 · 15 comments
Closed

Isogenies prime degree fails on some CM curves #32269

sachihashimoto mannequin opened this issue Jul 23, 2021 · 15 comments

Comments

@sachihashimoto
Copy link
Mannequin

sachihashimoto mannequin commented Jul 23, 2021

The code:

K.<a> = QuadraticField(-11)
E = EllipticCurve(K, [0,1,0,-117,-541])
E.isogenies_prime_degree(53)

returns an empty list. But, since E has CM by the ring of integers of K, it has to have an isogeny of degree p for p splitting in K, so this doesn't make sense.

If you import isogenies_prime_degree_general from isogeny_small_degree.py then

isogenies_prime_degree_general(E,53) 

correctly returns

[Isogeny of degree 53 from Elliptic Curve defined by y^2 = x^3 + x^2 + (-117)*x + (-541) over Number Field in a with defining polynomial x^2 + 11 with a = 3.316624790355400?*I to Elliptic Curve defined by y^2 = x^3 + x^2 + (98560*a+42123)*x + (-12561472*a-61946205) over Number Field in a with defining polynomial x^2 + 11 with a = 3.316624790355400?*I,
 Isogeny of degree 53 from Elliptic Curve defined by y^2 = x^3 + x^2 + (-117)*x + (-541) over Number Field in a with defining polynomial x^2 + 11 with a = 3.316624790355400?*I to Elliptic Curve defined by y^2 = x^3 + x^2 + (-98560*a+42123)*x + (12561472*a-61946205) over Number Field in a with defining polynomial x^2 + 11 with a = 3.316624790355400?*I]

CC: @alexjbest

Component: elliptic curves

Keywords: isogeny, CM

Author: Alex J. Best

Branch/Commit: 6b6dc19

Reviewer: Edgar Costa

Issue created by migration from https://trac.sagemath.org/ticket/32269

@sachihashimoto sachihashimoto mannequin added this to the sage-9.4 milestone Jul 23, 2021
@alexjbest
Copy link
Contributor

Branch: u/alexjbest/isog-nf

@alexjbest
Copy link
Contributor

Commit: 96561b3

@alexjbest
Copy link
Contributor

New commits:

96561b3attempt to fix 32269

@alexjbest
Copy link
Contributor

Work Issues: wait for CI

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 23, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

251c829output

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 23, 2021

Changed commit from 96561b3 to 251c829

@alexjbest
Copy link
Contributor

Author: Alex J. Best

@edgarcosta
Copy link
Member

comment:5

LGTM, but that test with ell = 53 is not going to fly.

Why not ell = 37? it is equally broken and takes 1/6 of the time.

@alexjbest
Copy link
Contributor

comment:6

@edgarcosta, right the example in code uses l=37, it might still need marking as # long time though, I'm not sure.

@edgarcosta
Copy link
Member

comment:7

Upsidaisy! Ignore my comment then.

I was hoping that the patch bot would tell us what to do regarding the necessity of the marking as # long

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 26, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

6b6dc19fix doctest

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 26, 2021

Changed commit from 251c829 to 6b6dc19

@alexjbest
Copy link
Contributor

Changed work issues from wait for CI to none

@edgarcosta
Copy link
Member

Reviewer: Edgar Costa

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Aug 22, 2021
@vbraun
Copy link
Member

vbraun commented Sep 1, 2021

Changed branch from u/alexjbest/isog-nf to 6b6dc19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants