Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix polytopes_db_4d optional doctest #32290

Closed
slel opened this issue Jul 28, 2021 · 8 comments
Closed

Fix polytopes_db_4d optional doctest #32290

slel opened this issue Jul 28, 2021 · 8 comments

Comments

@slel
Copy link
Member

slel commented Jul 28, 2021

Part of #25536.

With optional package polytopes_db_4d installed:

$ git branch -v
* develop  bd073b49ba  Updated SageMath version to 9.4.rc0
$ OPT='build,dochtml,pip,polytopes_db_4d,sage,sage_spkg'
$ alias sagetest="sage -t --long --optional=$OPT"
$ sagetest src/sage/geometry/polyhedron/palp_database.py
...
sage -t --long --random-seed=0 src/sage/geometry/polyhedron/palp_database.py
**********************************************************************
File "src/sage/geometry/polyhedron/palp_database.py", line 427, in sage.geometry.polyhedron.palp_database.Reflexive4dHodge.__init__
Failed example:
    Reflexive4dHodge(1,101)  # optional - polytopes_db_4d
Expected:
    <class 'sage.geometry.polyhedron.palp_database.Reflexive4dHodge'>
Got:
    <sage.geometry.polyhedron.palp_database.Reflexive4dHodge object at 0x7fbe34dfb828>
**********************************************************************
1 item had failures:
   1 of   3 in sage.geometry.polyhedron.palp_database.Reflexive4dHodge.__init__
    [64 tests, 1 failure, 1.63 s]
----------------------------------------------------------------------
sage -t --long --random-seed=0 src/sage/geometry/polyhedron/palp_database.py  # 1 doctest failed
----------------------------------------------------------------------
Total time for all tests: 1.7 seconds
    cpu time: 1.3 seconds
    cumulative wall time: 1.6 seconds
Pytest is not installed, skip checking tests that rely on it.

Component: packages: optional

Keywords: palp_database, polytopes_db_4d

Author: Samuel Lelièvre

Branch/Commit: 69598af

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32290

@slel slel added this to the sage-9.4 milestone Jul 28, 2021
@slel
Copy link
Member Author

slel commented Jul 28, 2021

comment:1

Here is a branch with this proposed change:

             sage: from sage.geometry.polyhedron.palp_database import Reflexive4dHodge
             sage: Reflexive4dHodge(1,101)  # optional - polytopes_db_4d
-            <class 'sage.geometry.polyhedron.palp_database.Reflexive4dHodge'>
+            <sage.geometry.polyhedron.palp_database.Reflexive4dHodge object at ...>
         """
         dim = 4
         if data_basename is None:

Did that change between Python 2 and Python 3?

Or among Python 3.y.z versions, can it can depend on y?


New commits:

69598af32290: Fix optional polytopes_db_4d doctest

@slel
Copy link
Member Author

slel commented Jul 28, 2021

Branch: public/32290

@slel
Copy link
Member Author

slel commented Jul 28, 2021

Author: Samuel Lelièvre

@slel
Copy link
Member Author

slel commented Jul 28, 2021

Commit: 69598af

@mkoeppe
Copy link
Member

mkoeppe commented Aug 3, 2021

comment:2

LGTM

@mkoeppe
Copy link
Member

mkoeppe commented Aug 3, 2021

Reviewer: Matthias Koeppe

@slel
Copy link
Member Author

slel commented Aug 3, 2021

comment:3

Thanks!

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Aug 22, 2021
@vbraun
Copy link
Member

vbraun commented Sep 1, 2021

Changed branch from public/32290 to 69598af

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants