Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove base ring attribute for the class ModularFormsRing #32349

Closed
DavidAyotte opened this issue Aug 9, 2021 · 6 comments
Closed

Remove base ring attribute for the class ModularFormsRing #32349

DavidAyotte opened this issue Aug 9, 2021 · 6 comments

Comments

@DavidAyotte
Copy link
Member

After the implementation of the parent/element framework for the class ModularFormsRing in #31559, the __base_ring attribute was not removed in the code. This ticket aims to remove this attribute and associated method so that the class use the inherited parent base ring method instead.

This ticket is part of #31560.

Depends on #31559

CC: @videlec

Component: modular forms

Keywords: gsoc2021 modular forms ring base ring

Author: David Ayotte

Branch/Commit: 1960959

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/32349

@DavidAyotte DavidAyotte added this to the sage-9.5 milestone Aug 9, 2021
@DavidAyotte DavidAyotte self-assigned this Aug 9, 2021
@DavidAyotte
Copy link
Member Author

@DavidAyotte
Copy link
Member Author

Last 10 new commits:

1b9332emoved sage.modular.modform.find_generators.py in sage.rings, attempt at making decrecation work (without success)
68509f9deprecation, added missing newline
2e78c45revert to commit 7fdca22
99f8ab5renamed find_generators.py to ring.py, added deprecation
62a9484docstring updates, fixed weights_list method for zero element
ed90b5afixed deprecation, added deprecation for find_generators and basis_for_modform_space
d489a1fmoved deprecation doctests inside find_generators, fixed docstrings
bf19eecadded example info for GradedModularFormElement class, moved some doctests inside the `__init__` method (for coverage)
2e49907fix docbuild error
1960959removed base ring attribute, removed base_ring method

@DavidAyotte
Copy link
Member Author

Commit: 1960959

@DavidAyotte
Copy link
Member Author

comment:4

Only the last commit is pertinent (commit 1960959).

@videlec
Copy link
Contributor

videlec commented Aug 12, 2021

Reviewer: Vincent Delecroix

@vbraun
Copy link
Member

vbraun commented Sep 7, 2021

Changed branch from u/gh-DavidAyotte/remove_base_ring_attribute to 1960959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants