Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unstable numeric doctest of LU decomposition #32350

Closed
mwageringel opened this issue Aug 9, 2021 · 7 comments
Closed

Fix unstable numeric doctest of LU decomposition #32350

mwageringel opened this issue Aug 9, 2021 · 7 comments
Labels
c: numerical p: major / 3 t: bug
Milestone
sage-9.5

Comments

@mwageringel
Copy link

This doctest can fail due to floating point precision problems:

File "src/sage/matrix/matrix_double_dense.pyx", line 1112, in sage.matrix.matrix_double_dense.Matrix_double_dense.LU
Failed example:
    m == P*L*U
Expected:
    True
Got:
    False

CC: @DavidAyotte

Component: numerical

Author: Markus Wageringel

Branch/Commit: da32e65

Reviewer: David Ayotte

Issue created by migration from https://trac.sagemath.org/ticket/32350
@mwageringel mwageringel added this to the sage-9.4 milestone Aug 9, 2021
@mwageringel
Copy link
Author

New commits:

da32e65fix unstable numeric doctest of LU decomposition

@mwageringel
Copy link
Author

Author: Markus Wageringel

@mwageringel
Copy link
Author

Branch: u/gh-mwageringel/32350

@mwageringel
Copy link
Author

Commit: da32e65

@mwageringel mwageringel modified the milestones: sage-9.4, sage-9.5 Aug 9, 2021
@DavidAyotte
Copy link
Member

Reviewer: David Ayotte

@DavidAyotte
Copy link
Member

comment:2

LGTM.

@vbraun
Copy link
Member

vbraun commented Sep 7, 2021

Changed branch from u/gh-mwageringel/32350 to da32e65

@vbraun vbraun closed this as completed in b24543d Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: numerical p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @DavidAyotte @mwageringel