Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage_setup.library_order: Skip libraries that were not detected #32373

Closed
mkoeppe opened this issue Aug 13, 2021 · 11 comments
Closed

sage_setup.library_order: Skip libraries that were not detected #32373

mkoeppe opened this issue Aug 13, 2021 · 11 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.5

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Aug 13, 2021

This is a follow-up on #31384 and a neutral change for normal builds of sagelib. Needed for #29865 (Modularization of sagelib: Break out separate packages sagemath-objects, sagemath-categories)

CC: @kiwifb @kliem @dimpase @antonio-rojas @orlitzky

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 676111f

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/32373
@mkoeppe mkoeppe added this to the sage-9.5 milestone Aug 13, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 13, 2021

Branch: u/mkoeppe/sage_setup_library_order__skip_libraries_that_were_not_detected

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 13, 2021

Commit: 4aff8a4

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 13, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 13, 2021

New commits:

4aff8a4sage_setup.library_order: Skip libraries that were not detected

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 28, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

676111fsage_setup.library_order: Take module list from new variables sage.env.default_{required,optional}_modules

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 28, 2021

Changed commit from 4aff8a4 to 676111f

@antonio-rojas
Copy link
Contributor

comment:7

Works fine for distro build

@orlitzky
Copy link
Contributor

comment:9

Makes sense.

@orlitzky
Copy link
Contributor

Reviewer: Michael Orlitzky

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 24, 2021

comment:10

Thanks!

@vbraun
Copy link
Member

vbraun commented Oct 9, 2021

Changed branch from u/mkoeppe/sage_setup_library_order__skip_libraries_that_were_not_detected to 676111f

@vbraun vbraun closed this as completed in 9693ce2 Oct 9, 2021
@mkoeppe mkoeppe mentioned this issue Jan 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
4 participants
@vbraun @orlitzky @mkoeppe @antonio-rojas