Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sqlite3 to sqlite/distros/cygwin.txt #32399

Closed
slel opened this issue Aug 19, 2021 · 10 comments
Closed

Add sqlite3 to sqlite/distros/cygwin.txt #32399

slel opened this issue Aug 19, 2021 · 10 comments

Comments

@slel
Copy link
Member

slel commented Aug 19, 2021

The file sqlite/distros/cygwin.txt
has libsqlite3-devel but not sqlite3.

Without sqlite3, three doctests fail
in src/sage/tests/cmdline.py:

sage -t --long --random-seed=0 src/sage/tests/cmdline.py
**********************************************************************
File "src/sage/tests/cmdline.py", line 586, in sage.tests.cmdline.test_executable
Failed example:
    out.startswith("3.")
Expected:
    True
Got:
    False
**********************************************************************
File "src/sage/tests/cmdline.py", line 588, in sage.tests.cmdline.test_executable
Failed example:
    err
Expected:
    ''
Got:
    '/home/sage/sage/src/bin/sage: line 667: exec: sqlite3: not found\n'
**********************************************************************
File "src/sage/tests/cmdline.py", line 590, in sage.tests.cmdline.test_executable
Failed example:
    ret
Expected:
    0
Got:
    127
**********************************************************************
1 item had failures:
   3 of 221 in sage.tests.cmdline.test_executable
    [220 tests, 3 failures, ... s]
----------------------------------------------------------------------
sage -t --long --random-seed=0 src/sage/tests/cmdline.py  # 3 doctests failed
----------------------------------------------------------------------

Similar reports at #31377, #29398, #29002
see

Note sqlite is a standard spkg.

CC: @slel

Component: packages: standard

Keywords: sqlite, distros

Author: Samuel Lelièvre

Branch/Commit: ec69206

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/32399

@slel slel added this to the sage-9.5 milestone Aug 19, 2021
@slel
Copy link
Member Author

slel commented Aug 19, 2021

Branch: u/slelievre/32399

@slel
Copy link
Member Author

slel commented Aug 19, 2021

New commits:

ec69206Add sqlite3 to sqlite/distros/cygwin.txt

@slel
Copy link
Member Author

slel commented Aug 19, 2021

Commit: ec69206

@slel
Copy link
Member Author

slel commented Aug 19, 2021

Author: Samuel Lelièvre

@dimpase
Copy link
Member

dimpase commented Aug 22, 2021

comment:2

does the parser understand such multiline input here?

@slel
Copy link
Member Author

slel commented Aug 23, 2021

comment:3

Many build/pkgs/*/distros/*.txt files
are multiline, so I'm pretty sure yes.

@dimpase
Copy link
Member

dimpase commented Aug 23, 2021

comment:4

OK, fine.

@dimpase
Copy link
Member

dimpase commented Aug 23, 2021

Reviewer: Dima Pasechnik

@slel
Copy link
Member Author

slel commented Aug 23, 2021

comment:5

Thanks!

@vbraun
Copy link
Member

vbraun commented Sep 13, 2021

Changed branch from u/slelievre/32399 to ec69206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants