Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

annotations for super tableaux #32402

Closed
fchapoton opened this issue Aug 19, 2021 · 9 comments
Closed

annotations for super tableaux #32402

fchapoton opened this issue Aug 19, 2021 · 9 comments
Labels
c: combinatorics p: major / 3 t: enhancement
Milestone
sage-9.5

Comments

@fchapoton
Copy link
Contributor

and also full pep8 cleanup

CC: @tscrim @slel @kliem

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: b724923

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32402
@fchapoton fchapoton added this to the sage-9.5 milestone Aug 19, 2021
@fchapoton
Copy link
Contributor Author

Commit: b724923

@fchapoton
Copy link
Contributor Author

New commits:

b724923some annotations for super tableaux

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/32402

@fchapoton
Copy link
Contributor Author

comment:2

green bot, please review

@tscrim
Copy link
Collaborator

tscrim commented Aug 21, 2021

comment:3

Do we need this line?

from __future__ import annotations

@fchapoton
Copy link
Contributor Author

comment:4

I have been forced by reviewers to add it in every file that contains annotations.

The idea is that the annotation system only get a little stable in python 3.10, after a bunch of incompatible and random changes in python 3.7,3.8,3.9. This line make sure we use the final (?) behaviour.

@tscrim
Copy link
Collaborator

tscrim commented Aug 25, 2021

comment:5

Okay. LGTM.

(I might have accidentally removed that in some other file in another ticket...)

@tscrim
Copy link
Collaborator

tscrim commented Aug 25, 2021

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Sep 13, 2021

Changed branch from u/chapoton/32402 to b724923

@vbraun vbraun closed this as completed in 1dc7e82 Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton