Remove deprecated module sage.matrix.matrix and method Matrix_integer_dense.__invert_unit

[mkoeppe]

sage.matrix.matrix was deprecated 4 years ago in #24096.

Matrix_integer_dense.__invert_unit was deprecated 3 years ago in #25084.

We remove them.

CC: @videlec @slel @tscrim

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: cebc952

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32417

[mkoeppe]

Branch: u/mkoeppe/remove_deprecated_module_sage_matrix_matrix

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

New commits:

f902733	sage.matrix.matrix: Remove deprecated module
9f8e5e3	Matrix_integer_dense.__invert_unit: Remove deprecated method

[mkoeppe]

Commit: 9f8e5e3

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:3

LGTM.

[mkoeppe]

comment:4

Thanks!

[vbraun]

comment:5

Merge conflict

[sagetrac-git]

Changed commit from 9f8e5e3 to cebc952

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

bcc2397	sage.matrix.matrix: Remove deprecated module
cebc952	Matrix_integer_dense.__invert_unit: Remove deprecated method

[mkoeppe]

comment:7

trivial rebase

[kiwifb]

comment:8

I get quite a lot of failure building sage since Volker has put it in its develop branch to test merging this morning

Error compiling Cython file:
------------------------------------------------------------
...

from .encoder import Encoder
from .decoder import Decoder, DecodingError

from sage.modules.free_module_element cimport FreeModuleElement
from sage.matrix.matrix cimport Matrix
^
------------------------------------------------------------

sage/coding/ag_code_decoders.pyx:73:0: 'sage/matrix/matrix.pxd' not found

Error compiling Cython file:
------------------------------------------------------------
...

from .encoder import Encoder
from .decoder import Decoder, DecodingError

from sage.modules.free_module_element cimport FreeModuleElement
from sage.matrix.matrix cimport Matrix
^
------------------------------------------------------------

sage/coding/ag_code_decoders.pyx:73:0: 'sage/matrix/matrix/Matrix.pxd' not found

and associated errors that Matrix is not defined. The above error is found across numerous files.

[mkoeppe]

comment:9

Yes, looks like something went wrong here. Incremental builds didn't catch this.

[mkoeppe]

comment:10

Fixed in #32530.

[vbraun]

Changed branch from u/mkoeppe/remove_deprecated_module_sage_matrix_matrix to cebc952