Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pip, setuptools, wheel, tox, virtualenv and related packages for Sage 9.5 #32482

Closed
mkoeppe opened this issue Sep 6, 2021 · 37 comments
Closed

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Sep 6, 2021

A set of updates to the latest versions - https://repology.org/projects/?inrepo=sagemath_develop&outdated=True

Other (disjoint) set of updates of Python packages:

Depends on #32493

CC: @dimpase @jhpalmieri

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: 6b64599

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/32482

@mkoeppe mkoeppe added this to the sage-9.5 milestone Sep 6, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 6, 2021

Branch: u/mkoeppe/update_pip_to_21_2_4

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 6, 2021

Commit: 80ad6ba

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 6, 2021

New commits:

80ad6babuild/pkgs/pip: Update to 21.2.4

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title Update pip to 21.2.4 Update pip, setuptools, wheel, tox, virtualenv and related packages for Sage 9.5 Sep 6, 2021
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 6, 2021

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

d7161e8build/pkgs/setuptools_scm: Update to 6.3.1
c03fd2cbuild/pkgs/tox: Update to 3.24.3
cd402c4build/pkgs/virtualenv: Update to 20.7.2
7d15f3fbuild/pkgs/importlib_resources: Update to 5.2.2
23d5ea0build/pkgs/pluggy: Update to 1.0.0
92ffb3abuild/pkgs/packaging: Update to 21.0
ea8b05fbuild/pkgs/importlib_metadata: Update to 4.8.1
eaa5358build/pkgs/pkgconfig: Update to 1.5.5
ac16b98build/pkgs/six: Update to 1.16.0
4b1a1afbuild/pkgs/wheel: Update to 0.37.0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 6, 2021

Changed commit from 80ad6ba to 4b1a1af

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 6, 2021

comment:4

Our patch build/pkgs/setuptools/patches/distutils-big-sur-6511bf56.patch (workaround for MACOSX_DEPLOYMENT_TARGET=11, added in #31335) no longer applies. The code has changed a lot and is now in (https://github.com/pypa/setuptools/blob/1ba66c1d79bf2e89d1d7be426bde60298c9439cd/setuptools/_distutils/util.py#L140). I don't see the workaround reflected by the new code.

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 6, 2021

comment:5

(from #31335 comment:36)
Upstream cpython issue:​ https://bugs.python.org/issue42504

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 6, 2021

comment:6

apparently fixed in upstream cpython 3.10 (python/cpython#24341), 3.9.2 (python/cpython#24410), 3.8.10 (python/cpython#25806)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 6, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

0f7da4fbuild/pkgs/setuptools/patches/distutils-big-sur-6511bf56.patch: Remove

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 6, 2021

Changed commit from 4b1a1af to 0f7da4f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 6, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

59132abbuild/pkgs/tomli: New, dependency of setuptools_scm
7ebcb6cbuild/pkgs/setuptools_scm/dependencies: Add packaging
2def651build/pkgs/{packaging,pyparsing,setuptools_scm}/dependencies: Avoid circular deps

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 6, 2021

Changed commit from 0f7da4f to 2def651

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 6, 2021

comment:9

Running into a strange circular dependency for packaging

packaging-21.0] Installing packaging-21.0
[packaging-21.0] Processing /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/var/tmp/sage/build/packaging-21.0/src
[packaging-21.0]     Preparing wheel metadata: started
[packaging-21.0]     Running command /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/bin/python3 /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py prepare_metadata_for_build_wheel /var/folders/38/wnh4gf1552g_crsjnv2vmmww0000gp/T/tmpk9l4wmep
[packaging-21.0]     Traceback (most recent call last):
[packaging-21.0]       File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 349, in <module>
[packaging-21.0]         main()
[packaging-21.0]       File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 331, in main
[packaging-21.0]         json_out['return_val'] = hook(**hook_input['kwargs'])
[packaging-21.0]       File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 151, in prepare_metadata_for_build_wheel
[packaging-21.0]         return hook(metadata_directory, config_settings)
[packaging-21.0]       File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/lib/python3.9/site-packages/setuptools/build_meta.py", line 166, in prepare_metadata_for_build_wheel
[packaging-21.0]         self.run_setup()
[packaging-21.0]       File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/lib/python3.9/site-packages/setuptools/build_meta.py", line 150, in run_setup
[packaging-21.0]         exec(compile(code, __file__, 'exec'), locals())
[packaging-21.0]       File "setup.py", line 40, in <module>
[packaging-21.0]         setup(
[packaging-21.0]       File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/lib/python3.9/site-packages/setuptools/__init__.py", line 153, in setup
[packaging-21.0]         return distutils.core.setup(**attrs)
[packaging-21.0]       File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/lib/python3.9/site-packages/setuptools/_distutils/core.py", line 108, in setup
[packaging-21.0]         _setup_distribution = dist = klass(attrs)
[packaging-21.0]       File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/lib/python3.9/site-packages/setuptools/dist.py", line 450, in __init__
[packaging-21.0]         _Distribution.__init__(
[packaging-21.0]       File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 293, in __init__
[packaging-21.0]         self.finalize_options()
[packaging-21.0]       File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/lib/python3.9/site-packages/setuptools/dist.py", line 827, in finalize_options
[packaging-21.0]         for ep in sorted(loaded, key=by_order):
[packaging-21.0]       File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/lib/python3.9/site-packages/setuptools/dist.py", line 826, in <lambda>
[packaging-21.0]         loaded = map(lambda e: e.load(), filtered)
[packaging-21.0]       File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/lib/python3.9/site-packages/pkg_resources/__init__.py", line 2449, in load
[packaging-21.0]         self.require(*args, **kwargs)
[packaging-21.0]       File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/lib/python3.9/site-packages/pkg_resources/__init__.py", line 2472, in require
[packaging-21.0]         items = working_set.resolve(reqs, env, installer, extras=self.extras)
[packaging-21.0]       File "/Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/lib/python3.9/site-packages/pkg_resources/__init__.py", line 772, in resolve
[packaging-21.0]         raise DistributionNotFound(req, requirers)
[packaging-21.0]     pkg_resources.DistributionNotFound: The 'packaging>=20.0' distribution was not found and is required by the application
[packaging-21.0]     Preparing wheel metadata: finished with status 'error'
[packaging-21.0] WARNING: Discarding file:///Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/var/tmp/sage/build/packaging-21.0/src. Command errored out with exit status 1: /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/bin/python3 /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py prepare_metadata_for_build_wheel /var/folders/38/wnh4gf1552g_crsjnv2vmmww0000gp/T/tmpk9l4wmep Check the logs for full command output.
[packaging-21.0] ERROR: Command errored out with exit status 1: /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/bin/python3 /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py prepare_metadata_for_build_wheel /var/folders/38/wnh4gf1552g_crsjnv2vmmww0000gp/T/tmpk9l4wmep Check the logs for full command output.
[packaging-21.0] ********************************************************************************
[packaging-21.0] Error building a wheel for packaging-21.0

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 6, 2021

comment:10

This went away by doing make setuptools_scm-clean

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 6, 2021

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 6, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 7, 2021

comment:12
  [tomli-1.2.1]   ModuleNotFoundError: No module named 'flit_core'

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 7, 2021

comment:13

... so need #32483 or #31280

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 9, 2021

Dependencies: #31280, #32493

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 9, 2021

Changed commit from 2def651 to aceeeeb

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 9, 2021

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

e2fb5cebuild/pkgs/ipywidgets: Update to 7.6.4
3e2fb34Merge #31280
00f06a6build/pkgs/{bleach,html5lib,importlib_resources,sagenb_export}/dependencies: Add missing deps
ac8bce8Merge #31280
a15e3ebbuild/pkgs/{flit_core,jupyterlab_pygments,matplotlib_inline,nbclient,nbconvert}/dependencies: Add missing deps
dc094c0build/pkgs/{ipykernel,nbconvert}/dependencies: Add missing deps
c929321build/pkgs/nbclient/dependencies: fixup
41224afbuild/pkgs/nbconvert/dependencies: Add missing dep
0fc01d3build/pkgs/zipp: Update to 3.5.0
aceeeebMerge #32493

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 9, 2021

Changed commit from aceeeeb to bf15a7b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 9, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

bf15a7bbuild/pkgs/tomli/dependencies: Add flit_core

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 9, 2021

Changed commit from bf15a7b to f10ea0b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 9, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

432699dbuild/pkgs/flit_core/dependencies: Remove dep on toml again, replace PYTHON_TOOLCHAIN by pip only, to break circular dep
f10ea0bbuild/pkgs/tomli/dependencies: Replace PYTHON_TOOLCHAIN by pip only, to break circular dep

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 9, 2021

Changed commit from f10ea0b to 4bdbddd

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 9, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

4bdbdddbuild/pkgs/tomli/dependencies: Add toml because flit_core needs it at its runtime

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 9, 2021

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 14, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

6b64599Merge tag '9.5.beta1' into t/32482/update_pip_to_21_2_4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 14, 2021

Changed commit from 4bdbddd to 6b64599

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 14, 2021

Changed dependencies from #31280, #32493 to #32493

@jhpalmieri
Copy link
Member

comment:24

This looks good to me.

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 15, 2021

comment:25

Thank you!

@vbraun
Copy link
Member

vbraun commented Sep 19, 2021

Changed branch from u/mkoeppe/update_pip_to_21_2_4 to 6b64599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants