Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement edge polytope and symmetric edge polytope of a graph #32498

Closed
kliem opened this issue Sep 10, 2021 · 16 comments
Closed

Implement edge polytope and symmetric edge polytope of a graph #32498

kliem opened this issue Sep 10, 2021 · 16 comments

Comments

@kliem
Copy link
Contributor

kliem commented Sep 10, 2021

We implement the edge polytope and the symmetric edge polytope of a graph.

CC: @jplab @mkoeppe @mantepse

Component: geometry

Keywords: SLC86, symmetric edge polytope

Author: Jonathan Kliem

Branch/Commit: 05890f4

Reviewer: Martin Rubey

Issue created by migration from https://trac.sagemath.org/ticket/32498

@kliem kliem added this to the sage-9.5 milestone Sep 10, 2021
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 10, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

fe16d78implement edge polytope and symmetric edge polytope

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 10, 2021

Commit: fe16d78

@dcoudert
Copy link
Contributor

comment:3

Just a few remarks:

  • the documentation says it's in \RR^n but the result is in ZZ
  • use enumerate(self) instead of enumerate(self.vertices() to avoid sorting vertices
  • Are these methods valid for both graphs and digraphs ? if only for graphs, then move them in graph.py

@kliem
Copy link
Contributor Author

kliem commented Sep 10, 2021

comment:4

They are valid for both graphs and digraphs. The direction is completely ignored as everything is symmetric (also for the not symmetric edge polytope, its just the polytope that is less symmetric, not the construction.

@mantepse
Copy link
Contributor

comment:5
However, there are still many different SEPs:

is missing a ":"

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 10, 2021

Changed commit from fe16d78 to dc22154

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 10, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

dc22154small fixes

@dcoudert
Copy link
Contributor

comment:7

Can you also add the methods to the tables (csv-table) at the top of file geneirc_graph.py.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 10, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

c27d5b5add methods to CSV table

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 10, 2021

Changed commit from dc22154 to c27d5b5

@mantepse
Copy link
Contributor

comment:9

Very tiny things:

  • There is an unused import.
src/sage/graphs/generic_graph.py:9516:9 'sage.misc.functional.round' imported but unused
  • replace
All trees on `n` vertices have isomorphic EP::

with

All trees on `n` vertices have isomorphic EPs::

and similarly for SEP

  • replace
is a polytope in `\ZZ^{n}` defined as the convex hull of

with

is the polytope in `\ZZ^{n}` defined as the convex hull of
  • replace
A non-trivial example of two graphs with isomorphic SEP::

with

A non-trivial example of two graphs with isomorphic SEPs::

If you agree, please set it to pos. rev. on my behalf! (and thank you!)

@mantepse
Copy link
Contributor

Reviewer: Martin Rubey

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 13, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

05890f4minor changes

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 13, 2021

Changed commit from c27d5b5 to 05890f4

@kliem
Copy link
Contributor Author

kliem commented Sep 13, 2021

comment:11

Thank you.

@vbraun
Copy link
Member

vbraun commented Sep 19, 2021

Changed branch from u/gh-kliem/symmetric_edge_polytope to 05890f4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants