New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade cvxopt to 1.2.7 for python 3.10 #32519
Comments
New commits:
|
Commit: |
comment:4
I think we should wait and give upstream some time to respond, at least until python-3.10 is released and available in mainstream distros. Otherwise we will end up supporting python-3.10 only via patches and rejecting system packages on distros that don't have the unofficial patches. |
comment:5
Note the pull request is from early spring this year... |
comment:6
Replying to @orlitzky:
We don't use system packages for any Python packages, so this is a non-issue |
comment:7
Replying to @mkoeppe:
.. yet. One of the obstacles standing in our way (although not a problem unique to python packages) is custom patching. If we have to patch, we can patch; it just seems a little early for the nuclear option. |
comment:8
Replying to @orlitzky:
Frankly it's pretty unrealistic for the Sage distribution to support it any time soon. I've sketched the best approach in #29023 and it's pretty complicated.
I agree (see #31543) that the Sage library should not depend on custom patched Python packages. But this cannot stop us to fix the Sage distribution so that it does not run into build problems. Note in particular that this build problem (of a standard package!) stops developers from actually testing Python 3.10 and therefore blocks necessary progress in our library. If it helps, think of the Sage distribution as a reference environment for developers.
That's a little dramatic. To stay within your metaphor, we already have dozens of nuclear plants running -- adding another one technically is to take the "nuclear option" but lacks the drama that this turn of phrase is meant to invoke. |
comment:10
Replying to @mkoeppe:
cvxopt's upstream is very, very slow at times. |
Upstream: Fixed upstream, but not in a stable release. |
This comment has been minimized.
This comment has been minimized.
comment:12
the pull request may be resolved but the vicious attack on my metaphor can't be undone |
comment:13
It was a conventional attack on your nuclear metaphor though |
Changed upstream from Fixed upstream, but not in a stable release. to Fixed upstream, in a later stable release. |
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/1242854091, https://github.com/mkoeppe/sage/actions/runs/1242854090 to none |
Reviewer: Dima Pasechnik |
comment:17
OK |
Changed branch from u/mkoeppe/patch_cvxopt_for_python_3_10 to |
cvxopt 1.2.7 has merged
cvxopt/cvxopt#190
Upstream: Fixed upstream, in a later stable release.
CC: @dimpase @orlitzky
Component: packages: standard
Author: Matthias Koeppe
Branch/Commit:
380b63a
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/32519
The text was updated successfully, but these errors were encountered: