Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cvxopt to 1.2.7 for python 3.10 #32519

Closed
mkoeppe opened this issue Sep 16, 2021 · 22 comments
Closed

Upgrade cvxopt to 1.2.7 for python 3.10 #32519

mkoeppe opened this issue Sep 16, 2021 · 22 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Sep 16, 2021

cvxopt 1.2.7 has merged
cvxopt/cvxopt#190

Upstream: Fixed upstream, in a later stable release.

CC: @dimpase @orlitzky

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: 380b63a

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/32519

@mkoeppe mkoeppe added this to the sage-9.5 milestone Sep 16, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 16, 2021

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 16, 2021

New commits:

9966a17build/pkgs/cvxopt/patches: Add https://github.com/cvxopt/cvxopt/pull/190

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 16, 2021

Commit: 9966a17

@orlitzky
Copy link
Contributor

comment:4

I think we should wait and give upstream some time to respond, at least until python-3.10 is released and available in mainstream distros. Otherwise we will end up supporting python-3.10 only via patches and rejecting system packages on distros that don't have the unofficial patches.

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 17, 2021

comment:5

Note the pull request is from early spring this year...

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 17, 2021

comment:6

Replying to @orlitzky:

Otherwise we will end up supporting python-3.10 only via patches and rejecting system packages on distros that don't have the unofficial patches.

We don't use system packages for any Python packages, so this is a non-issue

@orlitzky
Copy link
Contributor

comment:7

Replying to @mkoeppe:

We don't use system packages for any Python packages

.. yet. One of the obstacles standing in our way (although not a problem unique to python packages) is custom patching.

If we have to patch, we can patch; it just seems a little early for the nuclear option.

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 17, 2021

comment:8

Replying to @orlitzky:

Replying to @mkoeppe:

We don't use system packages for any Python packages

.. yet.

Frankly it's pretty unrealistic for the Sage distribution to support it any time soon. I've sketched the best approach in #29023 and it's pretty complicated.

One of the obstacles standing in our way (although not a problem unique to python packages) is custom patching.

I agree (see #31543) that the Sage library should not depend on custom patched Python packages.

But this cannot stop us to fix the Sage distribution so that it does not run into build problems. Note in particular that this build problem (of a standard package!) stops developers from actually testing Python 3.10 and therefore blocks necessary progress in our library.

If it helps, think of the Sage distribution as a reference environment for developers.

If we have to patch, we can patch; it just seems a little early for the nuclear option.

That's a little dramatic. To stay within your metaphor, we already have dozens of nuclear plants running -- adding another one technically is to take the "nuclear option" but lacks the drama that this turn of phrase is meant to invoke.

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 18, 2021

@dimpase
Copy link
Member

dimpase commented Sep 18, 2021

comment:10

Replying to @mkoeppe:

Note the pull request is from early spring this year...

cvxopt's upstream is very, very slow at times.

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 19, 2021

Upstream: Fixed upstream, but not in a stable release.

@mkoeppe

This comment has been minimized.

@orlitzky
Copy link
Contributor

comment:12

the pull request may be resolved but the vicious attack on my metaphor can't be undone

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 19, 2021

comment:13

It was a conventional attack on your nuclear metaphor though

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 21, 2021

Changed upstream from Fixed upstream, but not in a stable release. to Fixed upstream, in a later stable release.

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title Patch cvxopt for python 3.10 Upgrade cvxopt to 1.2.7 for python 3.10 Sep 21, 2021
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 21, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

380b63abuild/pkgs/cvxopt: Update to 1.2.7 for Python 3.10 compatibility

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 21, 2021

Changed commit from 9966a17 to 380b63a

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 21, 2021

@dimpase
Copy link
Member

dimpase commented Sep 21, 2021

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Sep 21, 2021

comment:17

OK

@vbraun
Copy link
Member

vbraun commented Oct 10, 2021

Changed branch from u/mkoeppe/patch_cvxopt_for_python_3_10 to 380b63a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants