Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared library versioning for flint #3259

Closed
timabbott opened this issue May 19, 2008 · 5 comments
Closed

shared library versioning for flint #3259

timabbott opened this issue May 19, 2008 · 5 comments

Comments

@timabbott
Copy link
Contributor

I've attached a patch which should add shared library versioning to libflint.so.

It includes the relevant patch for the Debian package and spkg-install, and also the relevant change s to the Debian packaging.

CC: @kiwifb

Component: packages: standard

Issue created by migration from https://trac.sagemath.org/ticket/3259

@timabbott
Copy link
Contributor Author

Attachment: flint-soname.patch.gz

@timabbott
Copy link
Contributor Author

comment:1

I forgot to note this, but because flint doesn't have a static library, we only need to build it with -fPIC, which is accomplished by setting MAKECMDGOALS=library

@kiwifb
Copy link
Member

kiwifb commented May 19, 2008

comment:2

I had forgotten about flint. Easy to do as my gentoo patch
is a one liner sed command to add a soname.

The patch to the makefile looks good to me, I won't comment
on the debian package rules. The makefile already use -fpic,
do you have to overrule that in debian?

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented May 28, 2008

comment:3

Patch looks good to me. The only issue along with #3300, i.e. that due to the copy operation we do not end up with a dynamic library and a link, but two identical copies. I fixed that in spkg-install. Positive review. The patches have been merged into

http://sage.math.washington.edu/home/mabshoff/release-cycles-3.0.3/alpha0/flint-1.06.p3.spkg

Cheers,

Michael

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented May 28, 2008

comment:4

Merged in Sage 3.0.3.alpha0

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed May 28, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants