Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipykernel: Missing dependency argcomplete for Python 3.7; remove obsolete scandir package #32626

Closed
mkoeppe opened this issue Oct 4, 2021 · 12 comments
Closed

ipykernel: Missing dependency argcomplete for Python 3.7; remove obsolete scandir package #32626

mkoeppe opened this issue Oct 4, 2021 · 12 comments
Labels
c: packages: standard p: critical / 2 t: bug
Milestone
sage-9.5

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Oct 4, 2021

From https://github.com/ipython/ipykernel/blob/v6.3.1/setup.py:

install_requires=[
        "ipython_genutils",
        'importlib-metadata<5;python_version<"3.8.0"',
        'argcomplete>=1.12.3;python_version<"3.8.0"',

CC: @kliem

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: b09693d

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/32626
@mkoeppe mkoeppe added this to the sage-9.5 milestone Oct 4, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 4, 2021

Branch: u/mkoeppe/ipykernel__missing_dependency_argcomplete_for_python_3_7

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 4, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 4, 2021

New commits:

f0bc1b4build/pkgs/argcomplete: New
1c95bacbuild/pkgs/ipykernel/dependencies: Add argcomplete and other missing deps

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 4, 2021

Commit: 1c95bac

@kliem
Copy link
Contributor

kliem commented Oct 5, 2021

Reviewer: Jonathan Kliem

@kliem
Copy link
Contributor

kliem commented Oct 5, 2021

comment:3

Works like a charm.

Why is scandir a dependency?

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 5, 2021

comment:4

Looks like scandir is obsolete for all supported Python versions - https://pypi.org/project/scandir/

Let's get rid of it

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 5, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

b09693dbuild/pkgs/scandir: Remove

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 5, 2021

Changed commit from 1c95bac to b09693d

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe mkoeppe changed the title ipykernel: Missing dependency argcomplete for Python 3.7 ipykernel: Missing dependency argcomplete for Python 3.7; remove obsolete scandir package Oct 5, 2021
@kliem
Copy link
Contributor

kliem commented Oct 5, 2021

comment:7

Thank you for the quick fix.

@vbraun
Copy link
Member

vbraun commented Oct 10, 2021

Changed branch from u/mkoeppe/ipykernel__missing_dependency_argcomplete_for_python_3_7 to b09693d

@vbraun vbraun closed this as completed in 244698d Oct 10, 2021
@mkoeppe mkoeppe mentioned this issue Nov 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: critical / 2 t: bug
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @mkoeppe @kliem