Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConvexSet_base, Polyhedron_base: In _test methods, do not fail if some modules are unavailable #32628

Closed
mkoeppe opened this issue Oct 5, 2021 · 8 comments
Closed

ConvexSet_base, Polyhedron_base: In _test methods, do not fail if some modules are unavailable #32628

mkoeppe opened this issue Oct 5, 2021 · 8 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.5

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Oct 5, 2021

(cherry-picked from #32432)

CC: @kliem

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 52ac1da

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/32628
@mkoeppe mkoeppe added this to the sage-9.5 milestone Oct 5, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 5, 2021

Branch: u/mkoeppe/convexset_base__polyhedron_base__in__test_methods__do_not_fail_if_some_modules_are_unavailable

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 5, 2021

New commits:

28dc817Polyhedron._test...: Avoid testing using unavailable functionality
52ac1daPolyhedron_base._test_gale_transform: Do not test is_combinatorially_isomorphic if sage.graphs.graphs not available

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 5, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 5, 2021

Commit: 52ac1da

@kliem
Copy link
Contributor

kliem commented Oct 5, 2021

Reviewer: Jonathan Kliem

@kliem
Copy link
Contributor

kliem commented Oct 5, 2021

comment:3

LGTM.

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 5, 2021

comment:4

Thanks!

@vbraun
Copy link
Member

vbraun commented Oct 19, 2021

Changed branch from u/mkoeppe/convexset_base__polyhedron_base__in__test_methods__do_not_fail_if_some_modules_are_unavailable to 52ac1da

@vbraun vbraun closed this as completed in 93abcdb Oct 19, 2021
@mkoeppe mkoeppe mentioned this issue Jan 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @mkoeppe @kliem