Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flit_core: Use sdh_pip_install --no-deps #32715

Closed
mkoeppe opened this issue Oct 18, 2021 · 11 comments
Closed

flit_core: Use sdh_pip_install --no-deps #32715

mkoeppe opened this issue Oct 18, 2021 · 11 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Oct 18, 2021

This is to suppress warnings that appear when installing flit_core.

Depends on #32751

CC: @vbraun @jhpalmieri @orlitzky

Component: build

Author: Matthias Koeppe

Branch/Commit: bc59753

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/32715

@mkoeppe mkoeppe added this to the sage-9.5 milestone Oct 18, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 24, 2021

Dependencies: #32751

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 24, 2021

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 24, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 24, 2021

New commits:

2d852adbuild/bin/sage-dist-helpers (sdh_pip_uninstall): Use build/bin/sage-pip-uninstall, resurrected in simplified form
b5a89adbuild/bin/sage-dist-helpers (sdh_store_and_pip_install_wheel): Uninstall before installing, to ensure the wheel is installed even if the version is the same
30a272ebuild/pkgs/sage_setup/dependencies: Add interpreter specs as dependencies
d435781build/bin/sage-dist-helpers (sdh_store_and_pip_install_wheel): Use sage-pip-uninstall
cc00d8cMerge #32659
516bdb3build/bin/sage-dist-helpers (sdh_pip_install): Handle new option --build-isolation
e89e278build/pkgs/packaging: Use --build-isolation
30e397cMerge #32751
e7558afbuild/bin/sage-dist-helpers (sdh_pip_install): Pass options on to sdh_store_and_pip_install_wheel
f61f788build/pkgs/flit_core/spkg-install.in: Use sdh_pip_install --no-deps

@mkoeppe
Copy link
Member Author

mkoeppe commented Oct 24, 2021

Commit: f61f788

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 28, 2021

Changed commit from f61f788 to bc59753

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 28, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

fd91cb6build/bin/sage-dist-helpers (sdh_pip_install): Pass options on to sdh_store_and_pip_install_wheel
8f3bd8fbuild/bin/sage-dist-helpers: Only extract special ooptions --build-isolation and --no-deps from the front, pass --no-deps only to install
bc59753build/pkgs/flit_core/spkg-install.in: Use sdh_pip_install --no-deps

@mkoeppe mkoeppe changed the title sdh_pip_install: Accept options such as --no-deps flit_core: Use sdh_pip_install --no-deps Oct 28, 2021
@orlitzky
Copy link
Contributor

orlitzky commented Nov 7, 2021

Reviewer: Michael Orlitzky

@orlitzky
Copy link
Contributor

orlitzky commented Nov 7, 2021

comment:7

Sure. I guess we don't add tomli to flit_core's dependencies because tomli already depends on flit_core?

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 7, 2021

comment:8

Thanks. Yes, that's right

@vbraun
Copy link
Member

vbraun commented Nov 15, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants