Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update database_knotinfo to 2021.10.1 #32760

Closed
soehms opened this issue Oct 25, 2021 · 12 comments
Closed

Update database_knotinfo to 2021.10.1 #32760

soehms opened this issue Oct 25, 2021 · 12 comments

Comments

@soehms
Copy link
Member

soehms commented Oct 25, 2021

The current version of database_knotinfo introduced an essential change that effects a couple of doctests. Explicitely they replaced many braid representatives of proper links by braids with smaller index. For example the braid of L4a1_0 changed like this:

-        '{4, {1, -2, 3, -2, -1, -2, -3, -2}}'
+        '{3, {-2, -2, -1, 2, -1}}'

Surely, this is an improvement which is worth to have it visible in Sage.

Component: packages: optional

Keywords: database knots links

Author: Sebastian Oehms

Branch/Commit: fea27fa

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32760

@soehms soehms added this to the sage-9.5 milestone Oct 25, 2021
@soehms

This comment has been minimized.

@soehms
Copy link
Member Author

soehms commented Oct 25, 2021

Branch: u/soehms/knotinfo_2021.10.1_32760

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 25, 2021

Commit: fea27fa

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 25, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

fea27fa32760: add braid_notation_old

@soehms
Copy link
Member Author

soehms commented Oct 25, 2021

comment:4

The only change of proper code I do is the adaption of the new braid representatives in the static dictionary of the demonstration cases. All other changes just concern the documentation.

The new braid representatives turned some tests for NotImplementedErrors of the method get_knotinfo to be successful. Therefore, I replace these examples by other test cases.

Note, that the correction of the optional doctest in link.py at line 3744 was not caused by the upgrade of the database but rather by ticket #30997 where it went unnoticed.

The former braid representatives are still kept in the database in a new column braid_notation_old. For compatibility reason I add this to the static dictionary of the demonstration cases.

For testing I started a GitHub workflow.

@soehms
Copy link
Member Author

soehms commented Oct 25, 2021

Author: Sebastian Oehms

@soehms
Copy link
Member Author

soehms commented Oct 25, 2021

Changed keywords from none to database knots links

@soehms
Copy link
Member Author

soehms commented Oct 26, 2021

comment:5

Test have passed. There are no failures related to ticket!

@tscrim
Copy link
Collaborator

tscrim commented Oct 27, 2021

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Oct 27, 2021

comment:6

LGTM.

@soehms
Copy link
Member Author

soehms commented Oct 27, 2021

comment:7

Thanks!

@vbraun
Copy link
Member

vbraun commented Oct 31, 2021

Changed branch from u/soehms/knotinfo_2021.10.1_32760 to fea27fa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants