Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the crystal iterator to use the new backtracking code #3278

Closed
mwhansen opened this issue May 23, 2008 · 4 comments
Closed

update the crystal iterator to use the new backtracking code #3278

mwhansen opened this issue May 23, 2008 · 4 comments
Assignees
@mwhansen
Labels
c: combinatorics p: minor / 4 t: bug
Milestone
sage-3.0.3

Comments

@mwhansen
Copy link
Contributor

CC: @sagetrac-sage-combinat

Component: combinatorics

Issue created by migration from https://trac.sagemath.org/ticket/3278
@mwhansen mwhansen added this to the sage-3.0.3 milestone May 23, 2008
@mwhansen mwhansen self-assigned this May 23, 2008
@mwhansen
Copy link
Contributor Author

Attachment: 3278.patch.gz

@dandrake
Copy link
Contributor

comment:1

Positive review, with one caveat: I didn't actually apply the patch and run the tests, because my Sage tree is messed up at the moment. mhansen on IRC said the tests pass...however, "because he said so on IRC" is an insult to the whole idea of review, so I feel like I should offer that warning. :)

@dandrake dandrake changed the title update the crystal iterator to use the new backtracking code [positive review with caveat] update the crystal iterator to use the new backtracking code May 26, 2008
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented May 26, 2008

comment:2

I applied the patch to my merge tree and "-testall -long" passed. Positive review.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin changed the title [positive review with caveat] update the crystal iterator to use the new backtracking code update the crystal iterator to use the new backtracking code May 26, 2008
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented May 26, 2008

comment:3

Merged in Sage 3.0.3.alpha0

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed May 26, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwhansen mwhansen

Labels
c: combinatorics p: minor / 4 t: bug
Projects
None yet
Milestone
sage-3.0.3
Development

No branches or pull requests
2 participants
@mwhansen @dandrake