Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove superfluous set_random_seed() calls #32877

Closed
orlitzky opened this issue Nov 15, 2021 · 13 comments
Closed

Remove superfluous set_random_seed() calls #32877

orlitzky opened this issue Nov 15, 2021 · 13 comments
Labels
p: major / 3 t: enhancement
Milestone
sage-9.6

Comments

@orlitzky
Copy link
Contributor

Now that we use a random random seed in doctests by default, any vintage calls to set_random_seed() are obsolete.

CC: @kliem

Component: misc

Author: Michael Orlitzky

Branch/Commit: 0c16a02

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/32877
@orlitzky orlitzky added this to the sage-9.5 milestone Nov 15, 2021
@orlitzky
Copy link
Contributor Author

Branch: u/mjo/ticket/32877

@orlitzky
Copy link
Contributor Author

Author: Michael Orlitzky

@orlitzky
Copy link
Contributor Author

New commits:

c6077dfTrac #32877: remove set_random_seed() calls from doctests.

@orlitzky
Copy link
Contributor Author

Commit: c6077df

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 1, 2021

Changed commit from c6077df to f976e17

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 1, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f976e17Trac #32877: remove set_random_seed() calls from doctests.

@kliem
Copy link
Contributor

kliem commented Dec 18, 2021

comment:4

The two instances in src/sage/misc/randstate.pyx should stay I believe. They illustrate the usage of the method set_random_seed.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 19, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0c16a02Trac #32877: remove set_random_seed() calls from doctests.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 19, 2021

Changed commit from f976e17 to 0c16a02

@orlitzky
Copy link
Contributor Author

comment:6

Replying to @kliem:

The two instances in src/sage/misc/randstate.pyx should stay I believe. They illustrate the usage of the method set_random_seed.

You're right, fixed.

@kliem
Copy link
Contributor

kliem commented Dec 20, 2021

comment:7

Thanks for doing this.

@kliem
Copy link
Contributor

kliem commented Dec 20, 2021

Reviewer: Jonathan Kliem

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Jan 28, 2022
@vbraun
Copy link
Member

vbraun commented Jan 31, 2022

Changed branch from u/mjo/ticket/32877 to 0c16a02

@vbraun vbraun closed this as completed in b36016a Jan 31, 2022
This was referenced Jan 29, 2023
Closed
Closed
@mkoeppe mkoeppe mentioned this issue Jan 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.6
Development

No branches or pull requests
4 participants
@vbraun @orlitzky @mkoeppe @kliem