Unstable doctest geometry/hyperbolic_space/hyperbolic_model.py

[kliem]

Part of #32544:

sage -t --long --random-seed=257293673212457698646690051018428858654 src/sage/geometry/hyperbolic_space/hyperbolic_model.py
**********************************************************************
File "src/sage/geometry/hyperbolic_space/hyperbolic_model.py", line 567, in sage.geometry.hyperbolic_space.hyperbolic_model.HyperbolicModel.random_geodesic
Failed example:
    bool((h.endpoints()[0].coordinates()).imag() >= 0)
Expected:
    True
Got:
    False
**********************************************************************
1 item had failures:
   1 of   3 in sage.geometry.hyperbolic_space.hyperbolic_model.HyperbolicModel.random_geodesic
    [234 tests, 1 failure, 0.77 s]
------------------------------------

CC: @orlitzky @tscrim @sagetrac-jhonrubia6

Component: doctest framework

Author: Michael Orlitzky

Branch/Commit: eddded5

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32891

[orlitzky]

comment:2

Wild ass guess: this should be testing HyperbolicPlane().UHP() and not HyperbolicPlane().PD(). The former stands for Upper Half Plane, the latter for Poincare Disk.

[tscrim]

comment:3

Indeed, that test is only valid for the UHP, but that method is already being tested. Here, we should test that the absolute value is at most 1 to test in the PD model.

[orlitzky]

Branch: u/mjo/ticket/32891

[orlitzky]

Author: Michael Orlitzky

[orlitzky]

New commits:

eddded5

Trac #32891: fix a failing hyperbolic model doctest.

[orlitzky]

Commit: eddded5

[tscrim]

comment:5

Thank you. LGTM.

[tscrim]

Reviewer: Travis Scrimshaw

[vbraun]

Changed branch from u/mjo/ticket/32891 to eddded5