Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer's guide: Add section on modularization #32899

Closed
mkoeppe opened this issue Nov 18, 2021 · 89 comments
Closed

Developer's guide: Add section on modularization #32899

mkoeppe opened this issue Nov 18, 2021 · 89 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Nov 18, 2021

We add a section to the developer manual, explaining packaging portions of the Sage library to distributions packages.

Related discussion in the sage devel:

https://groups.google.com/g/sage-devel/c/cTifWZOAfH8

See also: #32925 Improve documentation of sage.features

CC: @kwankyu @dimpase @tobiasdiez

Component: documentation

Author: Matthias Koeppe, Kwankyu Lee

Branch/Commit: b555735

Reviewer: Kwankyu Lee, Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32899

@mkoeppe mkoeppe added this to the sage-9.5 milestone Nov 18, 2021
@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 18, 2021

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 18, 2021

Commit: f85959b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 18, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

f85959bREADME.md: Update section Directory Layout

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 19, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

2494538src/doc/en/developer/packaging.rst: Update section 'Python-based packages'
0327ca8README.md: Update section Directory Layout
1d3a470src/doc/en/developer/python_packaging.rst: New

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 19, 2021

Changed commit from f85959b to 1d3a470

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 19, 2021

Changed commit from 1d3a470 to 7606c55

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 19, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

7606c55src/doc/en/developer/python_packaging.rst: Document distribution package source layout

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 19, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

70da678src/doc/en/developer/python_packaging.rst: Document dependencies

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 19, 2021

Changed commit from 7606c55 to 70da678

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 19, 2021

Changed commit from 70da678 to 3f80c6e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 19, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

3f80c6esrc/doc/en/developer/python_packaging.rst: Version constraints

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 19, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 19, 2021

comment:7

More to come in a follow-up ticket

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 21, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

190ee43src/doc/en/developer/python_packaging.rst: Add section on testing

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 21, 2021

Changed commit from 3f80c6e to 190ee43

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 21, 2021

Changed commit from 190ee43 to 8da48f2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 21, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

8da48f2src/doc/en/developer/python_packaging.rst: More on dependencies

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 21, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

5f99b19src/doc/en/developer/python_packaging.rst: Namespace packages

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 21, 2021

Changed commit from 8da48f2 to 5f99b19

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 22, 2021

Changed commit from 5f99b19 to c7e56f6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 22, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

c7e56f6src/doc/en/developer/python_packaging.rst: Explain monorepo

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 22, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

9a7096esrc/doc/en/developer/python_packaging.rst: Explain symlinks
ba0e4a8src/doc/en/developer/python_packaging.rst: Policy for distribution names

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 22, 2021

Changed commit from c7e56f6 to ba0e4a8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 22, 2021

Changed commit from ba0e4a8 to 6c97779

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 22, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

6c97779src/doc/en/developer/python_packaging.rst: Add remarks on reducing dependencies

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 23, 2021

comment:49

Thanks very much, this is a great improvement.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 23, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

7d6a44cUse :mod: as markup for packages/modules

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 23, 2021

Changed commit from c6fc111 to 7d6a44c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 23, 2021

Changed commit from 7d6a44c to f83d424

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 23, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

f83d424Improve ABC example

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 23, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

817a8d0src/doc/en/developer/packaging_sage_library.rst: More :mod: and :class: markup

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 23, 2021

Changed commit from f83d424 to 817a8d0

@mkoeppe

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 24, 2021

Changed commit from 817a8d0 to b555735

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 24, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

b555735src/doc/en/developer/packaging_sage_library.rst: Link to pypi.org and to documentation of packaging metadata

@kwankyu
Copy link
Collaborator

kwankyu commented Nov 24, 2021

comment:55

I am positive on the branch. Let's wait for green light.

@kwankyu
Copy link
Collaborator

kwankyu commented Nov 24, 2021

comment:56

Perhaps the patchbot failure is not genuine, but I will double check it.

Meanwhile, I have a question. Is it too late to name the distribution packages as sagelib-xxx? I think this name suggests that the distribution provides a portion of the sage library, which is true. Also in pkgs/, I see both distribution packages with names sage-xxx and sagemath-xxx. Here sagemath does not tell the difference between sage- packages and sagemath- packages.

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 24, 2021

comment:57

The distributions named sage-... use the package/module name: sage-setup distributes sage_setup, sage-conf distributes sage_conf etc.

Overall the name "sage" is heavily overloaded, on PyPI you see a number of completely unrelated packages. Using "sagelib" would not help with that.

"sagemath" is sufficiently specific.

@kwankyu
Copy link
Collaborator

kwankyu commented Nov 24, 2021

comment:58

I am okay with the branch. The patchbot failures are not genuine.

You can set it positive review if you are okay too.

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 24, 2021

comment:59

Thanks for the review and your contributions!

@vbraun
Copy link
Member

vbraun commented Dec 19, 2021

Changed branch from public/32899 to b555735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants