Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change parameter name #32922

Closed
thhagelmayer mannequin opened this issue Nov 22, 2021 · 7 comments
Closed

Change parameter name #32922

thhagelmayer mannequin opened this issue Nov 22, 2021 · 7 comments

Comments

@thhagelmayer
Copy link
Mannequin

thhagelmayer mannequin commented Nov 22, 2021

Change parameter name to be more descriptive.

Depends on #32278

CC: @behackl @cheuberg @dkrenn

Component: asymptotic expansions

Author: Thomas Hagelmayer

Branch/Commit: bca6e35

Reviewer: Benjamin Hackl

Issue created by migration from https://trac.sagemath.org/ticket/32922

@thhagelmayer thhagelmayer mannequin added this to the sage-9.5 milestone Nov 22, 2021
@thhagelmayer
Copy link
Mannequin Author

thhagelmayer mannequin commented Nov 22, 2021

@thhagelmayer
Copy link
Mannequin Author

thhagelmayer mannequin commented Nov 22, 2021

Commit: bca6e35

@thhagelmayer
Copy link
Mannequin Author

thhagelmayer mannequin commented Nov 22, 2021

comment:2

I changed the parameter self to expression in:

@staticmethod
    def B(expression, valid_from=0):
    ...
    return expression.B(valid_from)

Last 10 new commits:

f7c1823Merge branch 't/32214/term-monoids-unify-repr' into t/32215/refactor-element-construction-term-monoids
ba8efe6Merge branch 'u/gh-thhagelmayer/refactor-element-construction-term-monoids' of git://trac.sagemath.org/sage into t/32215/refactor-element-construction-term-monoids
51e035fTrac #32215: fix doctests (due to merge of #32214)
d763d66Trac #32215: full coverage of _element_constructor_
540d088Merge commit 'c11b2f4' into t/32215/refactor-element-construction-term-monoids
62cae10Trac #32215: fix doctest after merge
a84a2f2Merge branch 'u/dkrenn/refactor-element-construction-term-monoids' of trac.sagemath.org:sage into t/32229/bterms_conversion
84ad7a3Trac #32229: take absolute value of coefficient of BTerm
2474870Merge branch 'u/behackl/bterms_conversion' of trac.sagemath.org:sage into t/32278/add_support_for_b_terms_in_asymptotic_ring
bca6e35Trac #32922: Change parameter name to be more descriptive.

@thhagelmayer thhagelmayer mannequin added s: needs review and removed t: bug labels Nov 22, 2021
@behackl
Copy link
Member

behackl commented Nov 23, 2021

comment:4

Semantically, this makes sense. LGTM.

@behackl
Copy link
Member

behackl commented Nov 23, 2021

Reviewer: Benjamin Hackl

@slel
Copy link
Member

slel commented Jan 30, 2022

comment:5

Setting milestone to 9.6 now that 9.5 is out.

@slel slel modified the milestones: sage-9.5, sage-9.6 Jan 30, 2022
@vbraun
Copy link
Member

vbraun commented Mar 3, 2022

Changed branch from u/gh-thhagelmayer/change_parameter_name to bca6e35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants