Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ninja_build to 1.11.0, make it standard, add lower version bound #32992

Closed
dimpase opened this issue Dec 7, 2021 · 15 comments
Closed

update ninja_build to 1.11.0, make it standard, add lower version bound #32992

dimpase opened this issue Dec 7, 2021 · 15 comments
Labels
c: packages: standard p: major / 3 t: enhancement
Milestone
sage-9.7

Comments

@dimpase
Copy link
Member

dimpase commented Dec 7, 2021

This is preparation for scipy 1.9.0 (#34081), which switched to the meson toolchain.

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: 66af9c2

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/32992
@dimpase dimpase added this to the sage-9.5 milestone Dec 7, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 18, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 1, 2022
@mkoeppe
Copy link
Member

mkoeppe commented Aug 6, 2022

comment:3

The update is in #34081

@mkoeppe
Copy link
Member

mkoeppe commented Aug 6, 2022

Dependencies: #34081

@mkoeppe mkoeppe removed this from the sage-9.7 milestone Aug 6, 2022
@dimpase
Copy link
Member Author

dimpase commented Aug 8, 2022

comment:4

maybe spin it out from #34081, which is kind of too busy?

@mkoeppe
Copy link
Member

mkoeppe commented Aug 8, 2022

comment:5

OK

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Member

mkoeppe commented Aug 8, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Member

mkoeppe commented Aug 8, 2022

Changed dependencies from #34081 to none

@mkoeppe mkoeppe added this to the sage-9.7 milestone Aug 8, 2022
@mkoeppe mkoeppe changed the title update ninja_build, make it standard update ninja_build to 1.11.0, make it standard, add lower version bound Aug 8, 2022
@mkoeppe
Copy link
Member

mkoeppe commented Aug 8, 2022

Branch: u/mkoeppe/update_ninja_build_to_1_11_0__make_it_standard__add_lower_version_bound

@mkoeppe
Copy link
Member

mkoeppe commented Aug 8, 2022

Commit: 66af9c2

@mkoeppe
Copy link
Member

mkoeppe commented Aug 8, 2022

New commits:

3af0dd2build/pkgs/ninja_build/type: Change to standard
18bbc58build/pkgs/ninja_build: Update to 1.11.0
66af9c2build/pkgs/ninja_build/spkg-configure.m4: Set lower version bound to 1.8.2

@mkoeppe
Copy link
Member

mkoeppe commented Aug 8, 2022

comment:10

Tests ran at https://github.com/mkoeppe/sage/actions/runs/2794733722

@dimpase
Copy link
Member Author

dimpase commented Aug 8, 2022

comment:11

lgtm

@dimpase
Copy link
Member Author

dimpase commented Aug 8, 2022

Reviewer: Dima Pasechnik

@mkoeppe
Copy link
Member

mkoeppe commented Aug 8, 2022

comment:12

Thanks

@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 25, 2022
@vbraun
Copy link
Member

vbraun commented Aug 29, 2022

Changed branch from u/mkoeppe/update_ninja_build_to_1_11_0__make_it_standard__add_lower_version_bound to 66af9c2

@vbraun vbraun closed this as completed in 75d9213 Aug 29, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.7 Aug 31, 2022
This was referenced Aug 29, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
3 participants
@vbraun @dimpase @mkoeppe