Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cddlib a shared library #3304

Closed
timabbott opened this issue May 26, 2008 · 9 comments
Closed

Make cddlib a shared library #3304

timabbott opened this issue May 26, 2008 · 9 comments

Comments

@timabbott
Copy link
Contributor

Cddlib builds as a static library only. We should libtoolize it so that it installs static and dynamic libraries and .la files.

CC: @vbraun @sagetrac-mhampton

Component: debian-package

Keywords: editor_mabshoff

Issue created by migration from https://trac.sagemath.org/ticket/3304

@craigcitro
Copy link
Member

Changed keywords from none to editor_mabshoff

@craigcitro
Copy link
Member

comment:1

Attachment: cddlib-debian-shared-library.patch.gz

@sagetrac-mabshoff sagetrac-mabshoff mannequin changed the title Make cddlib Debian package use shared library [waiting on upstream] Make cddlib Debian package use shared library Jun 20, 2008
@timabbott
Copy link
Contributor Author

Attachment: cddlib-shared-library.patch.gz

@timabbott
Copy link
Contributor Author

comment:4

Earlier today I attached a version of the patch that doesn't mess with dist/debian (since that's no longer relevant).

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Feb 15, 2009

comment:5

Well, given how long we have been sitting on this reduce priority to critical.

Cheers,

Michael

@vbraun
Copy link
Member

vbraun commented Jan 27, 2010

comment:6

Has nothing to do with Debian, maybe that was misleading; summary changed.

The following spkg is patched in a similar way. It essentially contains tabbott's patch, but I found this report only after making the changes myself.

http://www.stp.dias.ie/~vbraun/cddlib-094f.p3.spkg

Users of the Fedora 12 binary sage distribution must manually re-install mpir-1.2.2.p0.spkg as discussed on http://groups.google.com/group/sage-devel/msg/aec4aa6b3874fe10. This is an unrelated bug of the build system.

@vbraun

This comment has been minimized.

@vbraun vbraun changed the title [waiting on upstream] Make cddlib Debian package use shared library Make cddlib a shared library Jan 27, 2010
@vbraun
Copy link
Member

vbraun commented Jan 31, 2010

comment:7

Superseded by #8115

@williamstein
Copy link
Contributor

comment:8
As I understand,

https://github.com/sagemath/sage-prod/issues/3304

should be just closed, not reviewed, since another ticket took care of
the issue.

Since only release managers should close tickets, I am leaving the
ticket as is and posting here.

Thank you,
Andrey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants