Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more direct conversion from QQbar to real and complex ball fields #33150

Closed
mezzarobba opened this issue Jan 11, 2022 · 20 comments
Closed

more direct conversion from QQbar to real and complex ball fields #33150

mezzarobba opened this issue Jan 11, 2022 · 20 comments

Comments

@mezzarobba
Copy link
Member

Implement _arb_(), _acb_() for algebraic numbers, providing a faster conversion path to real and complex ball fields than the one via _element_constructor_(). Conversions still go through RIF/CIF; the main benefit is that CBF(alg) no longer tests if alg is real.

Component: numerical

Author: Marc Mezzarobba

Branch/Commit: 1726b9e

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/33150

@mezzarobba mezzarobba added this to the sage-9.5 milestone Jan 11, 2022
@mezzarobba
Copy link
Member Author

Commit: 1fb11fe

@mezzarobba
Copy link
Member Author

@mezzarobba
Copy link
Member Author

New commits:

7307c9cRBF, CBF: provide prec(), for compatibility with RIF, CIF
1fb11feqqbar: more direct conversion to RBF, CBF

@slel
Copy link
Member

slel commented Jan 12, 2022

comment:3

Une courte explication dans la description du ticket?

@mezzarobba
Copy link
Member Author

comment:4

Replying to @slel:

Une courte explication dans la description du ticket?

Ben je n'ai pas grand-chose de plus à dire ; 'fin bon, j'ai mis une variante de ce qui est déjà dans les messages de commit.

@mezzarobba

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 17, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

9ef6bcaRBF, CBF: provide prec(), for compatibility with RIF, CIF
e05d4e2qqbar: more direct conversion to RBF, CBF

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 17, 2022

Changed commit from 1fb11fe to e05d4e2

@mezzarobba
Copy link
Member Author

comment:6

rebased

@fchapoton
Copy link
Contributor

comment:7

some failing doctests, see patchbot report

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 17, 2022

Changed commit from e05d4e2 to add511b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 17, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

add511bqqbar: more direct conversion to RBF, CBF

@mezzarobba
Copy link
Member Author

comment:9

Replying to @fchapoton:

some failing doctests, see patchbot report

Thanks!

@fchapoton
Copy link
Contributor

comment:10

one spurious import, see patchbot plugin

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 18, 2022

Changed commit from add511b to 1726b9e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 18, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

1726b9eqqbar: more direct conversion to RBF, CBF

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:12

ok, bon, feu vert

@mezzarobba
Copy link
Member Author

comment:13

merci !

@vbraun
Copy link
Member

vbraun commented Feb 21, 2022

Changed branch from u/mmezzarobba/33150-qqbar_to_ball_fields to 1726b9e

@vbraun vbraun closed this as completed in 9941688 Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants