Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage-conf_pypi does not build wheelhouse #33151

Closed
mkoeppe opened this issue Jan 11, 2022 · 13 comments
Closed

sage-conf_pypi does not build wheelhouse #33151

mkoeppe opened this issue Jan 11, 2022 · 13 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jan 11, 2022

Contrary to what is claimed in the README in https://pypi.org/project/sage-conf/9.5rc0/, after pip install sage_conf==9.5rc0, there is no wheelhouse available: ls $(sage-config SAGE_SPKG_WHEELS) gives "No such file or directory".

We fix this by changing make build-local to make build in the install script (and fixing a bug that caused make build to fail).

Distribution using the branch of this ticket uploaded as https://pypi.org/project/sage-conf/9.5rc0.post1/

CC: @dimpase

Component: distribution

Author: Matthias Koeppe

Branch/Commit: 04066ab

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/33151

@mkoeppe mkoeppe added this to the sage-9.5 milestone Jan 11, 2022
@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 12, 2022

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 12, 2022

Commit: 250e5e0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 12, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

250e5e0pkgs/sage-conf_pypi/setup.py: Use --disable-doc

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 12, 2022

Author: Matthias Koeppe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 12, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

04066abpkgs/sage-conf/README.rst: Add links to source code

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 12, 2022

Changed commit from 250e5e0 to 04066ab

@dimpase
Copy link
Member

dimpase commented Jan 12, 2022

comment:5

What is the aim of this ticket, it's a bit unclear from the description.

@mkoeppe

This comment has been minimized.

@dimpase
Copy link
Member

dimpase commented Jan 12, 2022

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Jan 12, 2022

comment:7

lgtm

@mkoeppe
Copy link
Member Author

mkoeppe commented Jan 12, 2022

comment:8

Thanks.

@vbraun
Copy link
Member

vbraun commented Jan 30, 2022

Changed branch from u/mkoeppe/sage_conf_pypi_does_not_build_wheelhouse to 04066ab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants