Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use parent function, not method, to convert SR to RBF or CBF #33157

Closed
mezzarobba opened this issue Jan 13, 2022 · 10 comments
Closed

Use parent function, not method, to convert SR to RBF or CBF #33157

mezzarobba opened this issue Jan 13, 2022 · 10 comments
Labels
c: symbolics p: major / 3 t: bug
Milestone
sage-9.6

Comments

@mezzarobba
Copy link
Member

Use parent(a) rather than a.parent()
to accommodate floats, ints, etc.

This fixes yet another issue with conversions
from symbolic expression to balls,
reported by Markus Wageringel at #32871.

In Sage 9.5.beta7:

sage: a = acos(float(1/4) * sqrt(int(5)))
sage: CBF(a)
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
...
AttributeError: 'float' object has no attribute 'parent'

With the fix in this ticket:

sage: CBF(acos(float(1/4) * sqrt(int(5))))
[0.97759655064526...]

CC: @slel

Component: symbolics

Author: Marc Mezzarobba

Branch/Commit: a995d14

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/33157
@mezzarobba mezzarobba added this to the sage-9.5 milestone Jan 13, 2022
@mezzarobba
Copy link
Member Author

Branch: u/mmezzarobba/33157-SRtoCBF

@mezzarobba
Copy link
Member Author

Commit: a995d14

@mezzarobba
Copy link
Member Author

New commits:

a995d14#33157 fix issue in SR → CBF conversion from #32871

@dimpase
Copy link
Member

dimpase commented Jan 13, 2022

comment:2

lgtm, thanks!

@dimpase
Copy link
Member

dimpase commented Jan 13, 2022

Reviewer: Dima Pasechnik

@mwageringel
Copy link

comment:3

Thank you.

@slel

This comment has been minimized.

Sign in to view
@slel slel changed the title Issue with SR → [RC]BF conversion Use parent function, not method, to convert SR to RBF or CBF Jan 25, 2022
@mwageringel

This comment has been minimized.

Sign in to view
@slel
Copy link
Member

slel commented Jan 30, 2022

comment:6

Setting milestone to 9.6 now that 9.5 is out.

@slel slel modified the milestones: sage-9.5, sage-9.6 Jan 30, 2022
@vbraun
Copy link
Member

vbraun commented Feb 13, 2022

Changed branch from u/mmezzarobba/33157-SRtoCBF to a995d14

@vbraun vbraun closed this as completed in 98fa6a8 Feb 13, 2022
@mezzarobba mezzarobba mentioned this issue Jan 13, 2022
Closed
@mkoeppe mkoeppe mentioned this issue Jan 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: symbolics p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.6
Development

No branches or pull requests
5 participants
@vbraun @dimpase @slel @mezzarobba @mwageringel