-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matrix_mod2_dense to/from PNG routines #3324
Comments
comment:1
REFEREE CHAT:
This fails to work on OS X PPC:
This fails to work on 32-bit Linux against vanilla 3.0.2 and exactly the same
|
comment:2
REFEREE REPORT: I read the code and it looks fine. However it doesn't build/work on any of my test platforms, and that's not so good. |
comment:3
The code depends on: #3204 (which is in 3.0.3.alpha0) so it won't work against 3.0.2. Sorry for not pointing that out earlier. I don't know about the OSX failure though. |
comment:4
I've updated the patch to avoid temporary files. |
Changed keywords from gd, gf(2) to gd, gf(2), editor_malb |
comment:7
wstein, can you review my update until 6/18? |
comment:8
Doesn't work on OS X:
|
new patch addresses review |
comment:9
Attachment: m4ri_png.patch.gz The attached patch addresses this issue. |
comment:11
This does not fix the problem for me:
|
comment:13
Are you 100% sure that you rebuilt with the patch applied? Note that I just replaced the patch and thus the download manager might have called in somewhat else when downloading. I'm just asking because it works for me on OSX. I'll try on a different machine though. |
comment:14
I cleanly applied the patch on bsd.math.washington.edu to a 100% fresh clean build of sage-3.0.3. It does not work. You should build sage on bsd, and get the patch to work there:
|
comment:15
State of affairs for editorial meeting 26/06/08 I do have a working copy on bsd and I'm trying to find out what exactly made it work for me. |
comment:16
Okay, I found it:
from |
comment:17
The problem with libpng.dylib is that certain spkgs like Python and R do not have LDFLAGS and CPPFLAGS set correctly so that on rebuilding them (on upgrade for example) we pick up the systems libpng which is broken. The issue has been corrected for Python, but some more work is needed for R and likely some other spkgs. Cheers, Michael |
comment:18
Guessing from William's failure above gd is also affected here. I believe #3792 will fix that issue. Cheers, Michael |
comment:19
I fixed all the problems on OSX in libpng.spkg, python.spkg and r.spkg and with those fixes the patch applies, builds correctly and all doctests pass on OSX. Positive review pending three other tickets I am about to open. Cheers, Michael |
comment:20
The spkgs at
fix the issues on OSX. Those three spkgs have been merged, so we can now merge this ticket. Cheers, Michael |
comment:21
Merged in Sage 3.1.2.alpha3 |
1-bit PNGs are a pretty sweet storage format for dense GF(2) matrices
So this patch adds
to_png
andfrom_png
functions tosage.matrix.matrix_mod2_dense
and uses those to implement pickling/unpickling.Component: linear algebra
Keywords: gd, gf(2), editor_malb
Issue created by migration from https://trac.sagemath.org/ticket/3324
The text was updated successfully, but these errors were encountered: