Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all direct uses of SAGE_TMP within doctests #33383

Closed
mkoeppe opened this issue Feb 19, 2022 · 7 comments
Closed

Replace all direct uses of SAGE_TMP within doctests #33383

mkoeppe opened this issue Feb 19, 2022 · 7 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Feb 19, 2022

Easy to review bulk changes, split out from #33213.

CC: @orlitzky @dimpase

Component: refactoring

Branch/Commit: u/mkoeppe/replace_all_direct_uses_of_sage_tmp_within_the_sage_library_and_doctests @ 9bcc16a

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/33383

@mkoeppe mkoeppe added this to the sage-9.6 milestone Feb 19, 2022
@mkoeppe mkoeppe changed the title Replace all direct uses of SAGE_TMP within the sage library and doctests Replace all direct uses of SAGE_TMP within doctests Feb 19, 2022
@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 19, 2022

@orlitzky
Copy link
Contributor

Commit: 9bcc16a

@orlitzky
Copy link
Contributor

comment:3

Can you give me a few days to work on this in #33213? I'm already planning to drop the removal of sage-cleaner (and the dependency on #8784) there, and to rebase it on your sage_makedirs branch, which I think will make this additional ticket redundant.

I'd also like to go back and clean up some of the commit messages, and don't want to proceed without knowing if the tempfile usage can be simplified wrt cygwin.


Last 10 new commits:

971b468Trac #33213: replace SAGE_TMP in probability distribution doctests.
c350febTrac #33213: replace SAGE_TMP in plot doctests.
af39498Trac #33213: replace SAGE_TMP in GLPK graph backend doctests.
f96b7f9Trac #33213: replace SAGE_TMP in R interface doctests.
e0b9f1eTrac #33213: replace SAGE_TMP in object persistence doctests.
239569bTrac #33213: replace SAGE_TMP in repl doctests.
b1b674aTrac #33213: replace SAGE_TMP in magma interface doctests.
7d21c03Trac #33213: replace SAGE_TMP in dist script doctests.
11e88e0Trac #33213: replace SAGE_TMP in MIP doctests.
9bcc16aTrac #33213: replace SAGE_TMP in session doctests.

@mkoeppe
Copy link
Member Author

mkoeppe commented Feb 20, 2022

comment:4

Sure, there's no rush

@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 17, 2022
@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 7, 2022

comment:6

No longer needed, as the full #33213 has been merged

@mkoeppe
Copy link
Member Author

mkoeppe commented Jul 7, 2022

Changed author from Michael Orlitzky to none

@mkoeppe mkoeppe removed this from the sage-9.7 milestone Jul 7, 2022
@dimpase
Copy link
Member

dimpase commented Jul 7, 2022

Reviewer: Dima Pasechnik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants