New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sage.graphs, sage.numerical.mip: Remove unnecessary uses of set_binary, set_integer #33504
Milestone
Comments
Author: Matthias Koeppe |
Commit: |
comment:3
LGTM. Green bot => positive review. |
Reviewer: Travis Scrimshaw |
comment:4
You did - flow = p.new_variable(nonnegative=True)
+ if integer:
+ flow = p.new_variable(nonnegative=True, integer=True)
+ else:
+ flow = p.new_variable(nonnegative=True) but why not simply - flow = p.new_variable(nonnegative=True)
+ flow = p.new_variable(nonnegative=True, integer=integer is True) |
comment:5
Replying to @dcoudert:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:7
Thanks, done |
Changed reviewer from Travis Scrimshaw to Travis Scrimshaw, David Coudert |
comment:8
Green bot |
comment:9
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We can avoid these methods that mutate variable type by setting up the correct variable type in the first place.
CC: @dcoudert
Component: linear programming
Author: Matthias Koeppe
Branch/Commit:
b82a512
Reviewer: Travis Scrimshaw, David Coudert
Issue created by migration from https://trac.sagemath.org/ticket/33504
The text was updated successfully, but these errors were encountered: