New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method is_integral_domain
for polynomial quotient rings
#33568
Comments
New commits:
|
This comment has been minimized.
This comment has been minimized.
Commit: |
comment:4
Remember to add your name in the "authors" field |
This comment has been minimized.
This comment has been minimized.
is_integral_domain
for polynomial quotient rings
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:6
With respect to the documentation. Anything after a
Instead of The test When
You indeed catch the |
comment:7
Thanks for taking a close look!
I'll change this.
Ok, I can do that, though one small comment: I believe in most cases this will mean that I only added this check since otherwise doctests about splitting algebras broke. There the problem was: one of these algebras was initialized knowing it is an integral domain, but then later it was also initialized as a quotient ring, and its previous
Yes, in retrospect I am also surprised - I'll change this.
It's true that there are two sources where the In fact the previous method |
comment:8
Replying to @schmittj:
The method
I think my misunderstanding comes from the weird semantic of the keyword |
comment:9
Replying to @videlec:
You might want to use what the generic
(see |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:11
I really like the proposal with |
Author: Johannes Schmitt |
comment:12
Are you sure about the semantic of |
Reviewer: Vincent Delecroix |
comment:14
In the documentation of
My impression is: if the primality tests have a nonzero chance of returning a false positive, then the implementation in |
comment:15
Thanks for the reference. I don't like very much this specification but changing it is definitely not the goal of this ticket. |
Changed branch from u/gh-schmittj/is_integral_domain_for_quotients to |
We add a method
is_integral_domain
to the
PolynomialQuotientRing
class.CC: @slel
Component: algebra
Author: Johannes Schmitt
Branch/Commit:
3173fbe
Reviewer: Vincent Delecroix
Issue created by migration from https://trac.sagemath.org/ticket/33568
The text was updated successfully, but these errors were encountered: