Upgrade sympow to 2.023.6 (for GCC 10 support)

[sagetrac-mabshoff]

Fork now maintained by the debian sympow maintainer (gh-jgmbenoit).

https://gitlab.com/rezozer/forks/sympow

Upstream URL: see checksums.ini

See also:

• Elliptic curve failures in 8.3.rc0: sympow issue #25856 Elliptic curve failures in 8.3.rc0: sympow issue

Upstream: Reported upstream. No feedback yet.

CC: @slel @timokau @saraedum @isuruf @antonio-rojas @orlitzky @embray @dimpase @tscrim

Component: packages: standard

Keywords: upgrade, sympow

Author: Timo Kaufmann, Matthias Koeppe

Branch/Commit: 2e3dd4d

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/3360

[sagetrac-mabshoff]

comment:1

The latest release is 1.023 at

http://magma.maths.usyd.edu.au/~watkins/sympow.tar.bz2
http://magma.maths.usyd.edu.au/~watkins/sympow.src.tar.bz2

Cheers,

Michael

[slel]

Changed keywords from none to upgrade, sympow

[kiwifb]

comment:7

Didn't realise there was a newer version. Considering sympow's code, an upgrade can only be an improvement.

[slel]

comment:8

See also #25099 "Add DESTDIR support for sympow".

[saraedum]

comment:9

sympow 1.023 segfaults (in Debian) on some inputs that used to work with 1.018

$ sympow -analrank -curve "[0,1,1,-2,0]"
sympow 1.023 RELEASE (Debian 1.023-8)  (c) Mark Watkins --- see README and COPYING for details
Minimal model of curve  is [0,1,1,-2,0]
At 389: Inertia Group is  C1 MULTIPLICATIVE REDUCTION
Conductor is 389
sp 1: Conductor at 389 is 1+0, root number is -1
sp 1: Euler factor at 389 is 1-1*x
1st sym power conductor is 389, global root number is 1
NT 1d0: 43
Maximal number of terms is 43
0.0E+00
Done with small primes 1049
Segmentation fault (core dumped)

[saraedum]

comment:10

This is essentially a known bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=863919. I submitted a patch for it on salsa: https://salsa.debian.org/science-team/sympow/merge_requests/1.

[timokau]

comment:12

In an effort to update the sympow package in nix, I contacted the debian maintainer (Jerome Benoit).

He told me that he really did receive their tarball in a private email (how did you guys manage to find that file on his homepage?). He also told me that "the upstream author is responsive (and he did not have a GIT because the code was written before the GIT revolution)".

Debian adds sage's patches and some more[1], as for example the bug fix saraedum mentions. It seems like Debian effectively became the new upstream of this package. I asked the maintainer if he had considered making it official and forking it, which he declined.

[1] https://salsa.debian.org/science-team/sympow/tree/master/debian/patches

[saraedum]

comment:13

Replying to @timokau:

He told me that he really did receive their tarball in a private email (how did you guys manage to find that file on his homepage?).

In my case: I wrote a private email to the sympow author and he told me about the URL.

He also told me that "the upstream author is responsive (and he did not have a GIT because the code was written before the GIT revolution)".
Debian adds sage's patches and some more[1], as for example the bug fix saraedum mentions. It seems like Debian effectively became the new upstream of this package. I asked the maintainer if he had considered making it official and forking it, which he declined.

[1] https://salsa.debian.org/science-team/sympow/tree/master/debian/patches

I was in correspondence with the sympow author about the recent segfault patch. Afterwards I proposed to move the project to github and basically take over maintenance but I have not heard back for a while since then.

[jgmbenoit]

comment:14

Is the URL still valid ?
Otherwise, after all, I may also consider to maintain a fork of sympow.

[timokau]

comment:15

sympow still seems to be hosted at that URL. Its just not advertised anywhere. But there are still all those semi-mandatory patches flying around that should probably be upstreamed. Having the project in some public version control would be great.

[slel]

comment:16

My notes about the url at
#25099 comment:13
still hold. Public version control of the original code
and the existing extra patches would definitely help,
as well as a home page for the project.

[jgmbenoit]

comment:17

I am on my way to fork sympow on gitlab. My concern will be only the unix part (read not the mathematical part) in view to harmonize related patches and integration in unix systems.
Notes: My time being counted and limited, it would be question of weekends, rather of days.

[timokau]

comment:18

Great! Thank you for doing that.

[vbraun]

comment:128

make[5]: Entering directory '/home/release/Sage/local/var/tmp/sage/build/sympow-2.023.6/src'
gcc   -O3  -std=gnu17 -fno-fast-math -mfpmath=sse -ffp-contract=on -DFPUCONTROLH   -c -o fpu.o fpu.c
gcc   -O3  -std=gnu17 -fno-fast-math -mfpmath=sse -ffp-contract=on -DFPUCONTROLH   -c -o analrank.o analrank.c
gcc   -O3  -std=gnu17 -fno-fast-math -mfpmath=sse -ffp-contract=on -DFPUCONTROLH   -c -o analytic.o analytic.c
gcc   -O3  -std=gnu17 -fno-fast-math -mfpmath=sse -ffp-contract=on -DFPUCONTROLH   -c -o compute.o compute.c
gcc   -O3  -std=gnu17 -fno-fast-math -mfpmath=sse -ffp-contract=on -DFPUCONTROLH   -c -o compute2.o compute2.c
gcc   -O3  -std=gnu17 -fno-fast-math -mfpmath=sse -ffp-contract=on -DFPUCONTROLH   -c -o help.o help.c
gcc   -O3  -std=gnu17 -fno-fast-math -mfpmath=sse -ffp-contract=on -DFPUCONTROLH   -c -o conductors.o conductors.c
gcc   -O3  -std=gnu17 -fno-fast-math -mfpmath=sse -ffp-contract=on -DFPUCONTROLH   -c -o disk.o disk.c
gcc   -O3  -std=gnu17 -fno-fast-math -mfpmath=sse -ffp-contract=on -DFPUCONTROLH   -c -o ec_ap.o ec_ap.c
gcc   -O3  -std=gnu17 -fno-fast-math -mfpmath=sse -ffp-contract=on -DFPUCONTROLH   -c -o ec_ap_bsgs.o ec_ap_bsgs.c
gcc   -O3  -std=gnu17 -fno-fast-math -mfpmath=sse -ffp-contract=on -DFPUCONTROLH   -c -o ec_ap_large.o ec_ap_large.c
gcc   -O3  -std=gnu17 -fno-fast-math -mfpmath=sse -ffp-contract=on -DFPUCONTROLH   -c -o eulerfactors.o eulerfactors.c
gcc   -O3  -std=gnu17 -fno-fast-math -mfpmath=sse -ffp-contract=on -DFPUCONTROLH   -c -o factor.o factor.c
gcc   -O3  -std=gnu17 -fno-fast-math -mfpmath=sse -ffp-contract=on -DFPUCONTROLH   -c -o generate.o generate.c
gcc   -O3  -std=gnu17 -fno-fast-math -mfpmath=sse -ffp-contract=on -DFPUCONTROLH   -c -o init_curve.o init_curve.c
generate.c: In function 'new_data':
generate.c:234:32: error: 'GP' undeclared (first use in this function)
  234 |  execlp(SH,SH,newdatascript,SH,GP,ARGS,NULL);}
      |                                ^~
generate.c:234:32: note: each undeclared identifier is reported only once for each function it appears in
gcc   -O3  -std=gnu17 -fno-fast-math -mfpmath=sse -ffp-contract=on -DFPUCONTROLH   -c -o main.o main.c
make[5]: *** [Makefile:39: generate.o] Error 1

[mkoeppe]

comment:129

on what machine

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

f522ea6

Merge tag '9.2.beta6' into t/3360/sympow-2.23.2

[sagetrac-git]

Changed commit from ae0f113 to f522ea6

[mkoeppe]

comment:131

Tests run at https://github.com/mkoeppe/sage/actions/runs/187726088

[mkoeppe]

comment:132

Builds correctly on all platforms.

[vbraun]

comment:133

Fedora 32 x86_64 for the record

[mkoeppe]

comment:134

Replying to @vbraun:

Fedora 32 x86_64 for the record

Thanks. Works fine on both fedora-32-minimal and fedora-32-standard (see above link). Would need more information about the system where it fails.

[vbraun]

comment:135

Still doesn't work. My build log has a

which: no gp in (/home/release/Sage/build/bin:/home/release/Sage/src/bin:/home/release/Sage/local/bin:/home/release/Sage/build/bin:/home/release/Sage/src/bin:/home/release/Sage/local/bin:/home/release/.local/bin:/home/release/opt/bin:/usr/share/Modules/bin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/home/release/.composer/vendor/bin)
*WARNING*: Could not find gp --- will not be able to build new_data

thats not in yours; Build race with pari/gp? Seems like this would explain the error: 'GP' undeclared

[mkoeppe]

comment:136

Yes, seems like we may need to add pari as a dependency

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

6173795	Merge tag '9.2.beta7' into t/3360/sympow-2.23.2
2e3dd4d	build/pkgs/sympow/dependencies: Add pari as an order-only dependency

[sagetrac-git]

Changed commit from f522ea6 to 2e3dd4d

[vbraun]

Changed branch from u/mkoeppe/sympow-2.23.2 to 2e3dd4d