Independence Poset

[sagetrac-nathanwilliams]

Software implementation of independence posets. Includes functions to compute maximal orthogonal pairs, tight orthogonal pairs, rowmotion, labelling, and generating Galois graphs of lattices.

Component: combinatorics

Branch/Commit: u/nathanwilliams/independence_poset @ af523f2

Issue created by migration from https://trac.sagemath.org/ticket/33659

[sagetrac-nathanwilliams]

Branch: u/nathanwilliams/independence_poset

[kcrisman]

Commit: 15076e9

[kcrisman]

comment:4

You have a bunch of extra files in here which probably should not have been in there (e.g. html). I would make a clean branch with only the actual changes in it (i.e., don't just delete those files and then commit again).

---

New commits:

15076e9

added independence_posets.py

[fchapoton]

comment:5

sage/combinat/independence_posets.py:123:23: E712 comparison to True should be 'if cond is True:' or 'if cond:'
16
sage/combinat/independence_posets.py:125:19: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
17
sage/combinat/independence_posets.py:249:19: E712 comparison to True should be 'if cond is True:' or 'if cond:'
18
sage/combinat/independence_posets.py:251:15: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
19
sage/combinat/independence_posets.py:293:10: E711 comparison to None should be 'if cond is None:'
20
sage/combinat/independence_posets.py:299:32: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
21
sage/combinat/independence_posets.py:303:16: E712 comparison to False should be 'if cond is False:' or 'if not cond:'

[kcrisman]

comment:6

There are also some formatting issues with very long lines - we tend to want something like 72-character lines for easy viewing in Terminals (or at least that used to be the case).

[fchapoton]

comment:7

and the doc does not build

[fchapoton]

comment:8

please never use "import *"

+src/sage/combinat/independence_posets.py:38:1 'sage.graphs.independent_sets.IndependentSets' imported but unused
+src/sage/combinat/independence_posets.py:39:1 'from sage.combinat.cyclic_sieving_phenomenon import *' used; unable to detect undefined names
+src/sage/combinat/independence_posets.py:302:25 'out' may be undefined, or defined from star imports: sage.combinat.cyclic_sieving_phenomenon
+src/sage/combinat/independence_posets.py:715:5 local variable 'D' is assigned to but never used

[sagetrac-git]

Changed commit from 15076e9 to 0383450

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

0383450

created branch with just relevant files

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

af523f2

Fixed semi-colon issue

[sagetrac-git]

Changed commit from 0383450 to af523f2

[fchapoton]

comment:11

should the branch here be replaced by

u/nathanwilliams/independence_posets

or not ?

[fchapoton]

comment:12

needs review or not ?

[fchapoton]

comment:13

still

sage/combinat/independence_posets.py:290:10: E711 comparison to None should be 'if cond is None:'

[fchapoton]

comment:14

and the branch is not clean, as can be seen by clicking on the "commits" link here above

[fchapoton]

comment:15

and you should rather act in your own name, not under Nathan's login and name